From: Andreas Schwab <schwab@linux-m68k.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: dengshaomin@cdjrlc.com, Sam Creasey <sammy@sammy.net>,
linux-m68k <linux-m68k@lists.linux-m68k.org>
Subject: Re: [PATCH] mm:%Lx is non-standard C
Date: Sun, 17 Jul 2022 11:42:06 +0200 [thread overview]
Message-ID: <87edykrs7l.fsf@igel.home> (raw)
In-Reply-To: <CAMuHMdUhGHXnd=tzLNKT-_enBfs_YZgAHNv6jeNTQ=c_e63urw@mail.gmail.com> (Geert Uytterhoeven's message of "Sun, 17 Jul 2022 11:26:45 +0200")
On Jul 17 2022, Geert Uytterhoeven wrote:
> CC linux-m68k.
>
> On Sat, Jul 16, 2022 at 6:10 PM shaom Deng <dengshaomin@cdjrlc.com> wrote:
>> replace %Lx with %lx, because %Lx is not standard
>>
>> Signed-off-by: shaom Deng <dengshaomin@cdjrlc.com>
>
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
> i.e. will queue in the m68k for-v5.20 branch.
>
>> --- a/arch/m68k/sun3/sun3dvma.c
>> +++ b/arch/m68k/sun3/sun3dvma.c
>> @@ -77,7 +77,7 @@ static void print_use(void)
>> pr_info("%d entries in use total\n", j);
>>
>> pr_info("allocation/free calls: %lu/%lu\n", dvma_allocs, dvma_frees);
>> - pr_info("allocation/free bytes: %Lx/%Lx\n", dvma_alloc_bytes,
>> + pr_info("allocation/free bytes: %lx/%lx\n", dvma_alloc_bytes,
>> dvma_free_bytes);
Does that actually work? The L modifier is equivalent to `ll', not `l',
and dvma_alloc_bytes and dvma_free_bytes are in fact of type unsigned
long long.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2022-07-17 9:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220716161022.16902-1-dengshaomin@cdjrlc.com>
2022-07-17 9:26 ` [PATCH] mm:%Lx is non-standard C Geert Uytterhoeven
2022-07-17 9:42 ` Andreas Schwab [this message]
2022-07-17 10:19 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edykrs7l.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=dengshaomin@cdjrlc.com \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=sammy@sammy.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox