From: Andreas Schwab <schwab@linux-m68k.org>
To: Hangyu Hua <hbh25y@gmail.com>
Cc: geert@linux-m68k.org, linux-m68k@lists.linux-m68k.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] m68k/kernel: array out of bound access in process_uboot_commandline
Date: Mon, 27 Dec 2021 10:19:31 +0100 [thread overview]
Message-ID: <87h7aus8v0.fsf@igel.home> (raw)
In-Reply-To: <20211227090917.35838-1-hbh25y@gmail.com> (Hangyu Hua's message of "Mon, 27 Dec 2021 17:09:17 +0800")
On Dez 27 2021, Hangyu Hua wrote:
> diff --git a/arch/m68k/kernel/uboot.c b/arch/m68k/kernel/uboot.c
> index 928dbd33fc4a..05eca6f653b5 100644
> --- a/arch/m68k/kernel/uboot.c
> +++ b/arch/m68k/kernel/uboot.c
> @@ -101,5 +101,8 @@ __init void process_uboot_commandline(char *commandp, int size)
> }
>
> parse_uboot_commandline(commandp, len);
> - commandp[len - 1] = 0;
> + if (len > 0)
> + commandp[len - 1] = 0;
> + else
> + commandp[0] = 0;
If len == 0 then even commandp[0] is OOB.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2021-12-27 9:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-27 9:09 [PATCH] m68k/kernel: array out of bound access in process_uboot_commandline Hangyu Hua
2021-12-27 9:19 ` Andreas Schwab [this message]
2021-12-27 11:52 ` Hangyu Hua
2021-12-27 11:56 ` Andreas Schwab
2021-12-27 12:50 ` Hangyu Hua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7aus8v0.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=geert@linux-m68k.org \
--cc=hbh25y@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox