From: Andreas Schwab <schwab@linux-m68k.org>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
"David Hildenbrand (Red Hat)" <david@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ankur Arora <ankur.a.arora@oracle.com>,
linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] m68k: Avoid -Wunused-but-set-parameter in clear_user_page()
Date: Sun, 24 May 2026 16:04:40 +0200 [thread overview]
Message-ID: <87qzn0q4xz.fsf@igel.home> (raw)
In-Reply-To: <20260524-m68k-clear_user_page-v1-1-4c950668842e@weissschuh.net> ("Thomas Weißschuh"'s message of "Sun, 24 May 2026 15:04:59 +0200")
On Mai 24 2026, Thomas Weißschuh wrote:
> diff --git a/arch/m68k/include/asm/page_mm.h b/arch/m68k/include/asm/page_mm.h
> index ed782609ca41..67c82c746f7a 100644
> --- a/arch/m68k/include/asm/page_mm.h
> +++ b/arch/m68k/include/asm/page_mm.h
> @@ -55,10 +55,12 @@ static inline void clear_page(void *page)
> #define clear_user_page(addr, vaddr, page) \
> do { clear_page(addr); \
> flush_dcache_page(page); \
> + (void)vaddr; \
> } while (0)
> #define copy_user_page(to, from, vaddr, page) \
> do { copy_page(to, from); \
> flush_dcache_page(page); \
> + (void)vaddr; \
Since vaddr is a macro parameter, I think it would be better to put it
in parens.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
prev parent reply other threads:[~2026-05-24 14:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-24 13:04 [PATCH] m68k: Avoid -Wunused-but-set-parameter in clear_user_page() Thomas Weißschuh
2026-05-24 14:04 ` Andreas Schwab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87qzn0q4xz.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=akpm@linux-foundation.org \
--cc=ankur.a.arora@oracle.com \
--cc=david@kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux@weissschuh.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox