Re: RFC: remove set_fs for m68k

Linus Torvalds
2021-09-14T15:54:47Z

On Mon, Sep 13, 2021 at 7:43 PM Michael Schmitz <schmitzmic@gmail.com> wrote:
>
> having run stress tests on a kernel with Al Viro's signal handling fixes
> applied for the past two days with no further errors, I am now quite
> confident that the format error I saw in resume_userspace() and a bus
> error in setup_frame() were caused by multiple pending signals, and the
> resulting stack mangling that Al's patches fix.

Sounds good. Except you say "Al Viro's signal handling fixes" without
giving any context, so I have no idea which patches you are referring
to.

Regardless, if there's some fixes queue that also removes set_fs()
from m68k, I'm willing to take it for 5.15 just to have another
architecture down and done with.

And even if the set_fs() patches might still be under discussion, the
format errors have been going on for some time, so the signal fixes -
wherever they are - seem to be no-brainers if they fix those.

Linus