Re: RFC: remove set_fs for m68k

Michael Schmitz
2021-07-15T05:44:19Z

Hi Andreas,

well spotted. I'll give that a try.

Cheers,

Michael

Am 15.07.2021 um 08:03 schrieb Andreas Schwab:
> diff --git a/arch/m68k/include/asm/uaccess.h b/arch/m68k/include/asm/uaccess.h
> index a308f0b41154..578e643ec83d 100644
> --- a/arch/m68k/include/asm/uaccess.h
> +++ b/arch/m68k/include/asm/uaccess.h
> @@ -193,22 +193,22 @@ do { \
>
> #define __get_kernel_nofault(dst, src, type, err_label) \
> do { \
> - type __gk_dst = *(type *)(dst); \
> + type *__gk_dst = (type *)(dst); \
> type *__gk_src = (type *)(src); \
> int __gk_err = 0; \
> \
> switch (sizeof(type)) { \
> case 1: \
> - __get_user_asm("move", __gk_err, __gk_dst, __gk_src, u8, b, d); \
> + __get_user_asm("move", __gk_err, *__gk_dst, __gk_src, u8, b, d); \
> break; \
> case 2: \
> - __get_user_asm("move", __gk_err, __gk_dst, __gk_src, u16, w, r); \
> + __get_user_asm("move", __gk_err, *__gk_dst, __gk_src, u16, w, r); \
> break; \
> case 4: \
> - __get_user_asm("move", __gk_err, __gk_dst, __gk_src, u32, l, r); \
> + __get_user_asm("move", __gk_err, *__gk_dst, __gk_src, u32, l, r); \
> break; \
> case 8: \
> - __get_user_asm8("move", __gk_err, __gk_dst, __gk_src); \
> + __get_user_asm8("move", __gk_err, *__gk_dst, __gk_src); \
> break; \
> default: \
> BUILD_BUG(); \
>
> Andreas.
>