Linux M68K Architecture development
 help / color / mirror / Atom feed
From: Michael Schmitz <schmitzmic@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@vger.kernel.org, Miro Kropacek <miro.kropacek@gmail.com>
Subject: Re: [PATCH v2 5/5] m68k: Add support for Svethlana
Date: Tue, 18 Aug 2026 06:57:59 +1200	[thread overview]
Message-ID: <94e542e0-af2f-aeec-e52e-28c4b31085df@gmail.com> (raw)
In-Reply-To: <CAMuHMdXPiizRPkT3ukiNoc-26dnqAKgkomsR8mYNxqSyh5bQ+g@mail.gmail.com>

Hi Geert,

Am 17.08.2026 um 20:52 schrieb Geert Uytterhoeven:
>> +#ifdef CONFIG_ATARI_SVETHLANA
>> +       {
>> +               int error;
>> +               void __iomem *sv_version;
>> +
>> +               sv_version = ioremap(ATARI_SV_VERSION_PHYS_ADDR, 4);
>> +               if (sv_version) {
>> +                       if (hwreg_present(sv_version) &&
>> +                           (__raw_readl(sv_version) & 0x3ff) >= 10)
>> +                               error = platform_device_register(&svethlana_device);
>> +                               if (error && !rv)
>> +                                       rv = error;
>
> Missing curly braces:
>
>     error: this ‘if’ clause does not guard... [-Werror=misleading-indentation]:

Oops - still does the right thing but just by accident ...

I'll respin, again...

Cheers,

	Michael

>
>> +                       iounmap(sv_version);
>> +               }
>> +       }
>> +#endif
>> +
>>  #ifdef CONFIG_ATARI_ETHERNEC
>>         {
>>                 int error;
>
> Gr{oetje,eeting}s,
>
>                         Geert
>

      reply	other threads:[~2026-08-17 18:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-16  7:37 [PATCH v2 0/5] m68k SuperVidel patches Michael Schmitz
2026-08-16  7:37 ` [PATCH v2 1/5] m68k: Fix atari mouse movement Michael Schmitz
2026-08-17  8:00   ` Geert Uytterhoeven
2026-08-16  7:37 ` [PATCH v2 2/5] fbdev: Give atafb proper parent Michael Schmitz
2026-08-16 14:38   ` Helge Deller
2026-08-16 18:37     ` Michael Schmitz
2026-08-17  6:34   ` Thomas Zimmermann
2026-08-17  7:49     ` Michael Schmitz
2026-08-17  7:57       ` Thomas Zimmermann
2026-08-17 19:11         ` Michael Schmitz
2026-08-16  7:37 ` [PATCH v2 3/5] fbdev: Add support for further video bit depths on atafb:external Michael Schmitz
2026-08-16  7:37 ` [PATCH v2 4/5] fbdev: Add support for SuperVidel's SuperBlitter Michael Schmitz
2026-08-16  7:37 ` [PATCH v2 5/5] m68k: Add support for Svethlana Michael Schmitz
2026-08-17  7:14   ` Geert Uytterhoeven
2026-08-17  8:50     ` Geert Uytterhoeven
2026-08-17  8:52   ` Geert Uytterhoeven
2026-08-17 18:57     ` Michael Schmitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=94e542e0-af2f-aeec-e52e-28c4b31085df@gmail.com \
    --to=schmitzmic@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=miro.kropacek@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox