public inbox for linux-m68k@lists.linux-m68k.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: gerg@snapgear.com
Cc: linux-m68k@vger.kernel.org, uclinux-dev@uclinux.org,
	Greg Ungerer <gerg@uclinux.org>
Subject: Re: [PATCH] m68k: merge mmu and non-mmu bitops.h
Date: Thu, 23 Jun 2011 19:30:48 +0200	[thread overview]
Message-ID: <BANLkTimmPO3Vyt-rxD2_9B3rsS-DWtho8g@mail.gmail.com> (raw)
In-Reply-To: <1308792524-22126-1-git-send-email-gerg@snapgear.com>

On Thu, Jun 23, 2011 at 03:28,  <gerg@snapgear.com> wrote:
> @@ -10,6 +10,9 @@ config ARCH_MAY_HAVE_PC_FDC
>  config ARCH_USES_GETTIMEOFFSET
>        def_bool y
>
> +config CPU_HAS_BITFIELDS
> +       bool
> +
>  config EISA
>        bool
>        ---help---
> @@ -223,6 +226,7 @@ comment "Processor type"
>
>  config M68020
>        bool "68020 support"
> +       select CPU_HAS_BITFIELDS
>        help
>          If you anticipate running this kernel on a computer with a MC68020
>          processor, say Y. Otherwise, say N. Note that the 68020 requires a

Upon second thought, this won't work for multi-CPU kernels, as there's
no runtime
check. The logic needs to be reverted, like:

config CPU_HAS_NO_BITFIELDS
        bool

config M680000
        bool "68000 support"
        select CPU_HAS_NO_BITFIELDS

so a kernel built to run on both 68000 and 68020 will not use the
bitfield instructions.
Sorry I didn't realize that earlier.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
_______________________________________________
uClinux-dev mailing list
uClinux-dev@uclinux.org
http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
This message was resent by uclinux-dev@uclinux.org
To unsubscribe see:
http://mailman.uclinux.org/mailman/options/uclinux-dev

  reply	other threads:[~2011-06-23 17:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-23  1:28 [PATCH] m68k: merge mmu and non-mmu bitops.h gerg
2011-06-23 17:30 ` Geert Uytterhoeven [this message]
2011-06-24  5:12   ` Greg Ungerer
  -- strict thread matches above, loose matches on Subject: below --
2011-06-24  5:45 gerg
2011-06-26 12:21 ` Geert Uytterhoeven
2011-06-27  2:10   ` Greg Ungerer
2011-06-03  6:51 gerg
2011-06-03 11:02 ` Finn Thain
2011-06-03 11:10   ` Greg Ungerer
2011-05-18  5:32 gerg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTimmPO3Vyt-rxD2_9B3rsS-DWtho8g@mail.gmail.com \
    --to=geert@linux-m68k.org \
    --cc=gerg@snapgear.com \
    --cc=gerg@uclinux.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=uclinux-dev@uclinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox