Re: [PATCH] m68k: merge the mmu and non-mmu versions of sys_m68k.c

[Geert Uytterhoeven <geert@linux-m68k.org>]

On Thu, Apr 21, 2011 at 04:55,  <gerg@snapgear.com> wrote:
> From: Greg Ungerer <gerg@uclinux.org>
>
> There is a lot of common code in the sys_m68k.c files. The mmu and non-mmu
> versions can easily be merged into a single file.
>
> There is really only 2 functions that differ in the 2 cases. A single
> ifdef on CONFIG_MMU can take care of this. Alternatively we could break
> those 2 functions out and maintain sys_m68k_no.c and sys_m68k_mm.c with
> just this code in it (Makefile could then just build the right one).
> Does anyone have strong feelings on which way they want this done?

I prefer one file with a few ifdefs, as it's more localized.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds