From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Jogi Dishank <jogidishank503@gmail.com>
Cc: linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org,
darshanrathod475@gmail.com,
Christophe Leroy <christophe.leroy@csgroup.eu>
Subject: Re: [PATCH] zorro: fix checkpatch error by avoiding assignment in if-statement.
Date: Tue, 29 Jul 2025 17:49:30 +0200 [thread overview]
Message-ID: <CAMuHMdW3JxeLEnbPqc8_Qvpr7mwHhsZoaWwB8QXTMbYRYW7-Aw@mail.gmail.com> (raw)
In-Reply-To: <CADorM-9OnP2zbtn6FHp-3NcO8nfnwC_RbzdcHdiUJCPXyMy8ig@mail.gmail.com>
Hi Jogi,
On Tue, 29 Jul 2025 at 14:10, Jogi Dishank <jogidishank503@gmail.com> wrote:
>
> Hi,
>
> Thank you for the suggestion.
>
> Additionally, the conditional logic is inverted to reduce indentation
> and improve readability, aligning with kernel coding style.
Thanks, but this is not how you send a v2.
Please read Documentation/process/submitting-patches.rst.
> Suggested-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Unless I am mistaken, Christophe merely pointed out a bug in
your first submission, he did not suggest this patch.
> Signed-off-by: Dishank Jogi <jogidishank503@gmail.com>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2025-07-29 15:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-28 9:34 [PATCH] zorro: fix checkpatch error by avoiding assignment in if-statement Dishank Jogi
2025-07-28 20:42 ` Christophe JAILLET
2025-07-29 7:08 ` Geert Uytterhoeven
2025-07-29 12:10 ` Jogi Dishank
2025-07-29 15:49 ` Geert Uytterhoeven [this message]
2025-07-29 15:31 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdW3JxeLEnbPqc8_Qvpr7mwHhsZoaWwB8QXTMbYRYW7-Aw@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=christophe.leroy@csgroup.eu \
--cc=darshanrathod475@gmail.com \
--cc=jogidishank503@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).