Re: [PATCH] m68k: apollo: replace strcpy() with strscpy()

[Geert Uytterhoeven <geert@linux-m68k.org>]

Hi Siddarth,

Thanks for your patch!

On Wed, 14 May 2025 at 07:23, Siddarth Gundu <siddarthsgml@gmail.com> wrote:
> strcpy() is deprecated; use strscpy() instead.
>
> strscpy was chosen because the code expects a NUL-terminated string
> without zero-padding.

... which are not sufficient reasons: there is no size information
about the destination buffer.

> Link: https://github.com/KSPP/linux/issues/88
> Signed-off-by: Siddarth Gundu <siddarthsgml@gmail.com>

> --- a/arch/m68k/apollo/config.c
> +++ b/arch/m68k/apollo/config.c
> @@ -218,7 +219,7 @@ static void dn_dummy_reset(void)
>
>  static void dn_get_model(char *model)
>  {
> -    strcpy(model, "Apollo ");
> +    strscpy(model, "Apollo ");

include/linux/compiler.h:197:62: error: static assertion failed: "must be array"
[...]
arch/m68k/apollo/config.c:222:5: note: in expansion of macro ‘strscpy’
  222 |     strscpy(model, "Apollo ");
      |     ^~~~~~~

Please try to (at least) test-compile your patches before submitting.

>      if (apollo_model >= APOLLO_DN3000 && apollo_model <= APOLLO_DN4500)
>          strcat(model, apollo_models[apollo_model - APOLLO_DN3000]);

FWIW, if the strscpy() would have prevented a buffer overflow, the
strcat() would still cause one.  But none of these can happen for real.
>  }

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds