From: Thorsten Blum <thorsten.blum@linux.dev>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Sam Creasey <sammy@sammy.net>,
linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] m68k: sun3: Use str_read_write() helper in mmu_emu_handle_fault()
Date: Sat, 1 Feb 2025 17:37:26 +0100 [thread overview]
Message-ID: <E7F49FB4-6DDF-47EA-97CA-8DFDC0D2F76C@linux.dev> (raw)
In-Reply-To: <CAMuHMdXFxSSm6cOkKprFrOcFzb1wZK1t3vRfooRZqEHDtGDb4A@mail.gmail.com>
On 20. Jan 2025, at 16:41, Geert Uytterhoeven wrote:
>> --- a/arch/m68k/sun3/mmu_emu.c
>> +++ b/arch/m68k/sun3/mmu_emu.c
>> @@ -371,7 +372,7 @@ int mmu_emu_handle_fault (unsigned long vaddr, int read_flag, int kernel_fault)
>>
>> #ifdef DEBUG_MMU_EMU
>> pr_info("%s: vaddr=%lx type=%s crp=%p\n", __func__, vaddr,
>> - read_flag ? "read" : "write", crp);
>> + str_read_write(read_flag), crp);
>
> You haven't really tested this with DEBUG_MMU_EMU enabled, have you?
> Fix sent.
Sorry, I missed this question.
I compile-tested it with DEBUG_MMU_EMU, but ignored the pr_info() error
you fixed in [1].
Thanks,
Thorsten
[1] https://lore.kernel.org/linux-kernel/b1d12a1d24b4aea9f98d905383ba932b2dc382e6.1737387419.git.geert@linux-m68k.org/
prev parent reply other threads:[~2025-02-01 16:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-17 12:06 [PATCH] m68k: sun3: Use str_read_write() helper in mmu_emu_handle_fault() Thorsten Blum
2025-01-20 15:41 ` Geert Uytterhoeven
2025-02-01 16:37 ` Thorsten Blum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E7F49FB4-6DDF-47EA-97CA-8DFDC0D2F76C@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=sammy@sammy.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox