From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [patch 17/18] net/rfkill/rfkill-input.c needs Date: Tue, 14 Oct 2008 09:23:42 +0200 (CEST) Message-ID: References: <20081013195846.674654386@mail.of.borg> <20081013195922.392078574@mail.of.borg> <20081013204559.GC28597@khazad-dum.debian.net> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from wilson.telenet-ops.be ([195.130.132.42]:58976 "EHLO wilson.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757342AbYJNHXr (ORCPT ); Tue, 14 Oct 2008 03:23:47 -0400 In-Reply-To: <20081013204559.GC28597@khazad-dum.debian.net> Sender: linux-m68k-owner@vger.kernel.org List-Id: linux-m68k@vger.kernel.org To: Henrique de Moraes Holschuh Cc: Linus Torvalds , linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org On Mon, 13 Oct 2008, Henrique de Moraes Holschuh wrote: > On Mon, 13 Oct 2008, Geert Uytterhoeven wrote: > > From: Geert Uytterhoeven > > > > For some m68k configs, I get: > > > > | net/rfkill/rfkill-input.c: In function 'rfkill_start': > > | net/rfkill/rfkill-input.c:208: error: dereferencing pointer to incomplete type > > > > As the incomplete type is `struct task_struct', including fixes > > it. > > Line 208 is this (in latest Linus mainline and also v2.6.27): > > spin_unlock_irq(&handle->dev->event_lock); > > So we need to include sched.h to everything that uses spin_unlock_irq? If > only some variants of m68k need that, shouldn't it have been added on the > header that defines spin_unlock_irq() on those arches, instead? Unfortunately that's not possible, due to Include Hell(tm). Therefore, including is the way this has been fixed in the past. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds