From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Michael Schmitz <schmitz@biophys.uni-duesseldorf.de>
Cc: Linux/m68k <linux-m68k@vger.kernel.org>
Subject: [PATCH/RFC] atafb and panning
Date: Sun, 16 Nov 2008 22:36:06 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.64.0811162235251.20005@anakin> (raw)
Fix panning on ARAnyM (Falcon emulation). Without this, `fbtest test011' fails
(for a 320x200x8 display with virtual 640x400).
As the original code in 2.4.x was the same, I'm wondering:
o Is this a bug in the ARAnyM emulation?
o xpanstep is 1, but judging from the visual output on ARAnyM, it looks like
it should be 16?
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/video/atafb.c | 2 ++
1 file changed, 2 insertions(+)
--- a/drivers/video/atafb.c
+++ b/drivers/video/atafb.c
@@ -1697,8 +1697,10 @@ static int falcon_pan_display(struct fb_
}
par->hw.falcon.line_offset = bpp *
(info->var.xres_virtual - info->var.xres) / 16;
+#if 0
if (par->hw.falcon.xoffset)
par->hw.falcon.line_offset -= bpp;
+#endif;
xoffset = var->xoffset - par->hw.falcon.xoffset;
par->screen_base = screen_base +
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next reply other threads:[~2008-11-16 21:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-16 21:36 Geert Uytterhoeven [this message]
2008-11-16 23:22 ` [PATCH/RFC] atafb and panning Petr Stehlík
2008-11-19 7:37 ` Michael Schmitz
2008-11-19 8:15 ` Geert Uytterhoeven
2008-11-19 8:51 ` Petr Stehlik
2008-11-22 7:16 ` Michael Schmitz
2008-11-22 8:45 ` Petr Stehlík
2008-11-23 13:03 ` Geert Uytterhoeven
[not found] ` <1227379735.6118.10.camel@joy>
[not found] ` <Pine.LNX.4.64.0811232242480.30025@anakin>
[not found] ` <alpine.DEB.1.00.0811240050090.15319@zirkon.biophys.uni-duesseldorf.de>
[not found] ` <Pine.LNX.4.64.0812141725090.5936@anakin>
[not found] ` <alpine.DEB.1.00.0812150457400.29644@zirkon.biophys.uni-duesseldorf.de>
2008-12-16 20:49 ` atari_mouse_interrupt_hook (was: Re: [PATCH/RFC] atafb and panning) Geert Uytterhoeven
2008-12-17 1:13 ` Michael Schmitz
2008-11-23 2:38 ` [PATCH/RFC] atafb and panning Michael Schmitz
2008-11-23 10:34 ` fbtest (was: Re: [PATCH/RFC] atafb and panning) Geert Uytterhoeven
2008-11-23 23:05 ` Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0811162235251.20005@anakin \
--to=geert@linux-m68k.org \
--cc=linux-m68k@vger.kernel.org \
--cc=schmitz@biophys.uni-duesseldorf.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox