From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: Fix support for console port other than ttyS0 on mcf.c Date: Wed, 4 Feb 2009 22:00:58 +0100 (CET) Message-ID: References: <20090204201518.GH26064@csclub.uwaterloo.ca> <20090204202009.GI26064@csclub.uwaterloo.ca> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from winston.telenet-ops.be ([195.130.137.75]:56021 "EHLO winston.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756160AbZBDVBF (ORCPT ); Wed, 4 Feb 2009 16:01:05 -0500 In-Reply-To: <20090204202009.GI26064@csclub.uwaterloo.ca> Sender: linux-m68k-owner@vger.kernel.org List-Id: linux-m68k@vger.kernel.org To: Lennart Sorensen Cc: Linux Kernel Development , linux-m68k@vger.kernel.org, uClinux list On Wed, 4 Feb 2009, Lennart Sorensen wrote: > Perhaps CCing linux-m68k@lists.linux-m68k.org would be a good idea. Thanks, but this is a uClinux driver. > On Wed, Feb 04, 2009 at 03:15:18PM -0500, Lennart Sorensen wrote: > > Due to a case of backwards logic, mfc.c always makes the console port be > > ttyS0 even when you ask for another port. > > > > This patch fixes this issue. > > > > Only when the requested port is NOT in the range 0 to MAXPORTS-1 do we > > force it to be treated as if port 0 was requested. Forcing the port to > > 0 when it is in fact in the range 0 to MAXPORTS is not helpful. > > > > Tested with working console on ttyS2 on a 5271evb. > > > > Signed-off-by: Len Sorensen > > > > diff --git a/drivers/serial/mcf.c b/drivers/serial/mcf.c > > index 56841fe..0eefb07 100644 > > --- a/drivers/serial/mcf.c > > +++ b/drivers/serial/mcf.c > > @@ -513,7 +513,7 @@ static int __init mcf_console_setup(struct console *co, char *options) > > int parity = 'n'; > > int flow = 'n'; > > > > - if ((co->index >= 0) && (co->index <= MCF_MAXPORTS)) > > + if ((co->index < 0) || (co->index >= MCF_MAXPORTS)) > > co->index = 0; > > port = &mcf_ports[co->index].port; > > if (port->membase == 0) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds