From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F7D9C64EC5 for ; Tue, 7 Feb 2023 22:55:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230121AbjBGWzX (ORCPT ); Tue, 7 Feb 2023 17:55:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230020AbjBGWzS (ORCPT ); Tue, 7 Feb 2023 17:55:18 -0500 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8521929430 for ; Tue, 7 Feb 2023 14:55:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675810517; x=1707346517; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=lx4c26ErU5S2ynIOqkxO2qwwwvS3CfD4nsakwC60WCg=; b=oB7lok1oJU9+dF9zaXIJ4oNCCj64FZ0lK58ybgq/H1I6PQB5cEuo6ztA 9q87Z394OJ2RyzpUDnVE4gMdzr7mJdPv1YflyC7/25ejN8TzIyI/rxY6l WX23LtBEel88Ml46WOXNNH0BqEWjMIAteQ92bQu2BhoJKiKdl0ta0wr1z SN6jFe3FJE8iwRF8kCfmLwC8XPmZfhu/LcbnR4F83cp2DI81Rj7CjzLbI w4SYVdFZuhN+7mzXZM8IUZjYlwA9fyoNWqtN5iRQalS4M9Rakk0pFmFtP S+qrt1YvkT11IWBWhlcPDAGAn8duFrs4d8A1M5Sh5XHQFlSDqwOAME02S A==; X-IronPort-AV: E=McAfee;i="6500,9779,10614"; a="309298592" X-IronPort-AV: E=Sophos;i="5.97,279,1669104000"; d="scan'208";a="309298592" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2023 14:55:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10614"; a="755794715" X-IronPort-AV: E=Sophos;i="5.97,279,1669104000"; d="scan'208";a="755794715" Received: from smile.fi.intel.com ([10.237.72.54]) by FMSMGA003.fm.intel.com with ESMTP; 07 Feb 2023 14:55:09 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pPWri-003on0-0X; Wed, 08 Feb 2023 00:55:06 +0200 Date: Wed, 8 Feb 2023 00:55:05 +0200 From: Andy Shevchenko To: Linus Walleij Cc: Arnd Bergmann , Bartosz Golaszewski , Geert Uytterhoeven , Christophe Leroy , Michael Ellerman , Dmitry Torokhov , Stefan Schmidt , Miquel Raynal , linux-gpio@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc-tw-discuss@lists.sourceforge.net, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-acpi@vger.kernel.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-wpan@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com, linux-arch@vger.kernel.org, devicetree@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH v3 06/12] gpiolib: split linux/gpio/driver.h out of linux/gpio.h Message-ID: References: <20230207142952.51844-1-andriy.shevchenko@linux.intel.com> <20230207142952.51844-7-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-m68k@vger.kernel.org On Tue, Feb 07, 2023 at 03:55:23PM +0100, Linus Walleij wrote: > On Tue, Feb 7, 2023 at 3:29 PM Andy Shevchenko > wrote: > > > From: Arnd Bergmann > > > > Almost all gpio drivers include linux/gpio/driver.h, and other > > files should not rely on includes from this header. > > > > Remove the indirect include from here and include the correct > > headers directly from where they are used. ... > Make sure you push this to the kernel.org build servers (zeroday builds), Of course, that is the purpose of publishing this before the release (so we will have some TODO list that eventually this can be applied for v6.4-rc1). > I think this patch needs to hit some more files, in my tests with a similar > patch at least these: Right. I forgot to also incorporate your stuff into this series. Do you have anything that I can take as is? -- With Best Regards, Andy Shevchenko