Re: [PATCH v2 4/4] mm, arch: add generic implementation of pfn_valid() for FLATMEM

Guenter Roeck
2023-02-12T17:38:47Z

On 2/12/23 08:26, Mike Rapoport wrote:
> Hi Guenter,
>
> On Sun, Feb 12, 2023 at 08:13:20AM -0800, Guenter Roeck wrote:
>> On Sun, Jan 29, 2023 at 02:42:35PM +0200, Mike Rapoport wrote:
>>> From: "Mike Rapoport (IBM)" <rppt@kernel.org>
>>>
>>> Every architecture that supports FLATMEM memory model defines its own
>>> version of pfn_valid() that essentially compares a pfn to max_mapnr.
>>>
>>> Use mips/powerpc version implemented as static inline as a generic
>>> implementation of pfn_valid() and drop its per-architecture definitions.
>>>
>>
>> With this patch in the tree, sh4 and sh4eb qemu emulations no longer boot.
>> Reverting this patch fixes the problem.
>
> Can you please test with only partial revert for arch/sh?
>

Sure, that works as well.

Guenter