From: Sam Ravnborg <sam@ravnborg.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
David Airlie <airlied@linux.ie>, Helge Deller <deller@gmx.de>,
Javier Martinez Canillas <javierm@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux/m68k <linux-m68k@vger.kernel.org>,
DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 2/8] drm/fb-helper: Add support for DRM_FORMAT_C[124]
Date: Thu, 17 Feb 2022 21:34:36 +0100 [thread overview]
Message-ID: <Yg6xXFouzq/4YCgU@ravnborg.org> (raw)
In-Reply-To: <CAMuHMdVK7eWfod73JQAntO=7BAMEcS-ktH4NJmDjna3zUn7giw@mail.gmail.com>
Hi Geert,
> > > + switch (fb->format->depth) {
> >
> > The depth field is deprecated. It's probably better to use
> > fb->format->format and test against 4CC codes.
>
> The reason I checked for depth instead of a 4CC code is that the only
> thing that matters here is the number of bits per pixel. Hence this
> function won't need any changes to support R1, R2, R4, and D1 later.
> When we get here, we already know that we are using a format that
> is supported by the fbdev helper code, and thus passed the 4CC
> checks elsewhere.
>
> Alternatively, we could introduce drm_format_info_bpp() earlier in
> the series, and use that?
The drm_format_info_bpp() is very descriptive, so yes it would be good to use
it here also.
Sam
next prev parent reply other threads:[~2022-02-17 20:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 16:52 [PATCH 0/8] drm: Add support for low-color frame buffer formats Geert Uytterhoeven
2022-02-15 16:52 ` [PATCH 1/8] drm/fourcc: Add DRM_FORMAT_C[124] Geert Uytterhoeven
2022-02-17 9:46 ` Pekka Paalanen
2022-02-15 16:52 ` [PATCH 2/8] drm/fb-helper: Add support for DRM_FORMAT_C[124] Geert Uytterhoeven
2022-02-17 14:57 ` Thomas Zimmermann
2022-02-17 16:12 ` Geert Uytterhoeven
2022-02-17 16:18 ` Simon Ser
2022-02-17 17:21 ` Geert Uytterhoeven
2022-02-17 20:34 ` Sam Ravnborg [this message]
2022-02-18 8:14 ` Thomas Zimmermann
2022-02-18 8:53 ` Geert Uytterhoeven
2022-02-15 16:52 ` [PATCH 3/8] drm/fourcc: Add drm_format_info_bpp() helper Geert Uytterhoeven
2022-02-15 16:52 ` [PATCH 4/8] drm/client: Use actual bpp when allocating frame buffers Geert Uytterhoeven
2022-02-17 14:58 ` Thomas Zimmermann
2022-02-15 16:52 ` [PATCH 5/8] drm/framebuffer: Use actual bpp for DRM_IOCTL_MODE_GETFB Geert Uytterhoeven
2022-02-15 16:52 ` [PATCH 6/8] drm/gem-fb-helper: Use actual bpp for size calculations Geert Uytterhoeven
2022-02-15 16:52 ` [PATCH 7/8] drm/fourcc: Add DRM_FORMAT_R[124] Geert Uytterhoeven
2022-02-17 10:02 ` Pekka Paalanen
2022-02-15 16:52 ` [PATCH 8/8] drm/fourcc: Add DRM_FORMAT_D1 Geert Uytterhoeven
2022-02-17 10:10 ` Pekka Paalanen
2022-02-17 10:42 ` Geert Uytterhoeven
2022-02-17 14:28 ` Pekka Paalanen
2022-02-17 14:35 ` Michel Dänzer
2022-02-17 20:36 ` Sam Ravnborg
2022-02-17 10:11 ` Simon Ser
2022-02-17 20:37 ` [PATCH 0/8] drm: Add support for low-color frame buffer formats Sam Ravnborg
2022-02-18 8:56 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yg6xXFouzq/4YCgU@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=javierm@redhat.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox