Re: [PATCH 2/3] amiga: cslab ata support

Geert Uytterhoeven
2025-03-24T09:38:30Z

Hi Paolo,

On Mon, 24 Mar 2025 at 10:10, Paolo Pisati <p.pisati@gmail.com> wrote:
> On Mon, Mar 24, 2025 at 09:17:57AM +0100, Geert Uytterhoeven wrote:
> > I started working on Zorro MFD a long time ago, but never finished...
> > https://web.git.kernel.org/pub/scm/linux/kernel/git/geert/linux-m68k.git/log/?h=zorro-mfd
>
> Uhm, that could be useful for this multi-device board, thanks!

As I still keep up-to-date patches in my current tree, I have rebased
the zorro-mfd branch.

> > > + /* Manually bind to all boards */
> > > + while ((z = zorro_find_device(ZORRO_PROD_CSLAB_WARP_CTRL, z))) {
> > > + static struct zorro_device_id cswarp_ent = {
> > > + ZORRO_PROD_CSLAB_WARP_CTRL, 0
> > > + };
> > > +
> > > + pata_cswarp_probe(z, &cswarp_ent);
> >
> > This looks very hackish to me...
> > I guess it blows up when trying to unbind either the zorro8390 or
> > cswarp driver?
>
> Yes, this was clearly wrong.

Oh, this was copied from drivers/ata/pata_buddha.c, which does the
same thing. How could I have missed that? Ah, Summer holidays...

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds