Re: [PATCH v3 1/2] ata: pata_cswarp: Add Amiga cslab ata support

Paolo Pisati
2025-03-25T15:55:35Z

On Mon, Mar 24, 2025 at 02:21:57PM +0100, Geert Uytterhoeven wrote:
> >
> > + }
> > + words++;
> > + }
> > +
> > + return words << 1;
>
> This can be one more than buflen, when the latter is odd.
> Why not just return buflen instead?

I think "every" m68k pata driver is buggy in this regard, e.g. pata_buddha,
pata_gayle, pata_falcon, etc
And words++ can go too.

> > +
> > + ata_port_desc(ap, " cmd 0x%lx ctl 0x%lx", (unsigned long)base,
> > + (unsigned long)ap->ioaddr.ctl_addr);
>
> These two printed addresses are virtual addresses.
> However, due to the use of a cast instead of ioremap(), they are identical.
> Still, I think it is better to print board + WARP_OFFSET_ATA and
> board + WARP_OFFSET_ATA + 0x1000 | (6UL << 2) instead.

Honestly i don't follow you here, but i'll ioremap() and send a v4.
--
bye,
p.