Re: [PATCH v3 1/2] ata: pata_cswarp: Add Amiga cslab ata support

Geert Uytterhoeven
2025-03-25T15:56:59Z

Hi Paolo,

On Tue, 25 Mar 2025 at 16:55, Paolo Pisati <p.pisati@gmail.com> wrote:
> On Mon, Mar 24, 2025 at 02:21:57PM +0100, Geert Uytterhoeven wrote:
> > > +
> > > + ata_port_desc(ap, " cmd 0x%lx ctl 0x%lx", (unsigned long)base,
> > > + (unsigned long)ap->ioaddr.ctl_addr);
> >
> > These two printed addresses are virtual addresses.
> > However, due to the use of a cast instead of ioremap(), they are identical.

... identical to the physical addresses.

> > Still, I think it is better to print board + WARP_OFFSET_ATA and
> > board + WARP_OFFSET_ATA + 0x1000 | (6UL << 2) instead.
>
> Honestly i don't follow you here, but i'll ioremap() and send a v4.

Thanks!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds