From: Yury Norov <yury.norov@gmail.com>
To: John Hubbard <jhubbard@nvidia.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Tamir Duberstein <tamird@gmail.com>,
David Gow <davidgow@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Naveen N Rao <naveen@kernel.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Shuah Khan <shuah@kernel.org>, Kees Cook <kees@kernel.org>,
Muhammad Usama Anjum <usama.anjum@collabora.com>,
linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
linuxppc-dev@lists.ozlabs.org, linux-kselftest@vger.kernel.org,
Brad Figg <bfigg@nvidia.com>,
David Hildenbrand <david@redhat.com>,
Michal Hocko <mhocko@suse.com>, Jason Gunthorpe <jgg@nvidia.com>
Subject: Re: distro support for CONFIG_KUNIT: [PATCH 0/3] bitmap: convert self-test to KUnit
Date: Mon, 10 Feb 2025 15:20:50 -0500 [thread overview]
Message-ID: <Z6pfomw-3LuWoQQo@thinkpad> (raw)
In-Reply-To: <bd71c705-5f57-4067-b200-fd80b98ddbc9@nvidia.com>
On Mon, Feb 10, 2025 at 11:35:48AM -0800, John Hubbard wrote:
> On 2/9/25 11:54 PM, Geert Uytterhoeven wrote:
> > On Sat, 8 Feb 2025 at 18:53, Yury Norov <yury.norov@gmail.com> wrote:
> > > On Fri, Feb 07, 2025 at 03:14:01PM -0500, Tamir Duberstein wrote:
> > > > On 7/27/24 12:35 AM, Shuah Khan wrote:
> ...
> > > > The crux of the argument seems to be that the config help text is taken
> > > > to describe the author's intent with the fragment "at boot". I think
> >
> > IMO, "at boot" is a misnomer, as most tests can be either builtin
> > or modular.
>
> Right.
>
> >
> > > KUNIT is disabled in defconfig, at least on x86_64. It is also disabled
> > > on my Ubuntu 24.04 machine. If I take your patches, I'll be unable to
>
> OK so I just bought a shiny new test machine, and installed one of the
> big name distros on it, hoping they've moved ahead and bought into the kunit
> story...
>
> $ grep KUNIT /boot/config-6.8.0-52-generic
> # CONFIG_KUNIT is not set
>
> ...gagghh! No such luck. One more data point, in support of Yuri's complaint. :)
>
> >
> > I think distros should start setting CONFIG_KUNIT=m.
>
> Yes they should! kunit really does have important advantages for many use
> cases, including bitmaps here, and "CONFIG_KUNIT is not set" is the main
> obstacle.
Hi John, Geert, Tamir,
Can you please explain in details which advantages KUNIT brings to
the test_bitmap.c, find_bit_benchmark.c and other low-level tests?
I'm not strongly against moving under KUNIT's hat, but I do:
- respect commitment of my contributors, so I don't want to wipe git
history for no serious reason;
- respect time of my testers, so no extra dependencies;
- respect time of reviewers.
Tamir,
If it comes to v2, can you please begin your series with an exhaustive
and clear answer to the following questions:
- What do the tests miss now?
- What do _you_ need from the tests? Describe your test scenario.
- How exactly KUNIT helps you testing bitmaps and friends better?
- Is there a way to meet your needs with a less invasive approach,
particularly without run-time dependencies?
Thanks,
Yury
next prev parent reply other threads:[~2025-02-10 20:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 20:14 [PATCH 0/3] bitmap: convert self-test to KUnit Tamir Duberstein
2025-02-07 20:14 ` [PATCH 1/3] bitmap: remove _check_eq_u32_array Tamir Duberstein
2025-02-08 9:07 ` David Gow
2025-02-08 18:00 ` Yury Norov
2025-02-10 5:22 ` Muhammad Usama Anjum
2025-02-07 20:14 ` [PATCH 2/3] bitmap: convert self-test to KUnit Tamir Duberstein
2025-02-08 9:07 ` David Gow
2025-02-10 5:22 ` Muhammad Usama Anjum
2025-02-10 7:42 ` Geert Uytterhoeven
2025-02-07 20:14 ` [PATCH 3/3] bitmap: break kunit into test cases Tamir Duberstein
2025-02-08 9:07 ` David Gow
2025-02-08 12:33 ` Tamir Duberstein
2025-02-10 5:23 ` Muhammad Usama Anjum
2025-02-08 9:07 ` [PATCH 0/3] bitmap: convert self-test to KUnit David Gow
2025-02-08 17:53 ` Yury Norov
2025-02-08 18:42 ` Tamir Duberstein
2025-02-10 7:54 ` Geert Uytterhoeven
2025-02-10 19:35 ` distro support for CONFIG_KUNIT: " John Hubbard
2025-02-10 19:46 ` David Hildenbrand
2025-02-10 23:10 ` Nico Pache
2025-02-10 23:41 ` John Hubbard
2025-02-10 20:20 ` Yury Norov [this message]
2025-02-10 22:01 ` Tamir Duberstein
2025-02-11 7:51 ` David Gow
2025-03-21 16:53 ` Tamir Duberstein
2025-03-21 18:32 ` Yury Norov
2025-03-21 19:47 ` Tamir Duberstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6pfomw-3LuWoQQo@thinkpad \
--to=yury.norov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bfigg@nvidia.com \
--cc=christophe.leroy@csgroup.eu \
--cc=david@redhat.com \
--cc=davidgow@google.com \
--cc=geert@linux-m68k.org \
--cc=jgg@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux@rasmusvillemoes.dk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mhocko@suse.com \
--cc=mpe@ellerman.id.au \
--cc=naveen@kernel.org \
--cc=npiggin@gmail.com \
--cc=shuah@kernel.org \
--cc=tamird@gmail.com \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).