From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2F191E3DED for ; Fri, 21 Mar 2025 18:32:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742581981; cv=none; b=Nh5pSpy4Q/+Mh4iCOoWqphJA0DTvjFQho3RbrOQKU9EOZ/qxX5VBsE3Y5UmrW3fVNILjyEOTMEDzb/RyC9Yd+N5BWtxkADfYLSE99X3Jlke3Mlzc5AMo1UNezebr1aHjMCPvNhUgkJHx1h+p7q/YAIYPrKQDtGqBId6ZoVzBtu4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742581981; c=relaxed/simple; bh=xK61NJ5AcpPTkZxqeIXw3ikD2Gq+iucUtG013FT56sI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mQsLgfUgUtkGbWpUtYhAPS1m0KbJaFlols2rOfSyfxt9HH1ArQrqWAxxvgU4RtonsGGjoK/cxINyiCb8rnRmD3fzxUfby9j8ijJ1onyTpGo6RbVX0zdVXmBL0ZLY4SLVGJ5EtFLfK95dqI2goRg6Gpt5tr16lWYVxCwYpR20mBM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hFD6HBRY; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hFD6HBRY" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-223fd89d036so46651795ad.1 for ; Fri, 21 Mar 2025 11:32:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742581979; x=1743186779; darn=lists.linux-m68k.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=HYYSOKUxEGqctY3EfhN9A2yhuGU3c7aUKlXkZitVseM=; b=hFD6HBRYR2T7BcNh9fzyRnScH0oVlfQPNj2yXidkFaCp7aBMKo8RMiY3NwwvQ3Tu6T QoAIwGQn+AEv7LQKNsGrdF/IdptXa+UH4DLLpp8izWOnH+vFCVymFL72Svik7zSw+/+p ZCENUyW/+aknYJ2OcoYb3KK3GTQojLg9jHSRcWhf9MJN57x4vF2cENjXkyzDWeaXHDLW /XivRaE2yXFtmXjf+bmtDCa21JgtI42exLBn8W1xMEl6ratCmDhkTHuLtbWcSue+gK1g tZh+w1W0lvlYp3YQhKuNAb7bcTPdeE/B36MDzWMn2bPS24N6AnLcVbuCar5P9/0msGOf lCoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742581979; x=1743186779; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HYYSOKUxEGqctY3EfhN9A2yhuGU3c7aUKlXkZitVseM=; b=uLhQV5dm8XhLwnqGwQ/dMTYADSoajsuAAdpz+b7qzatviRqiRiNblS2JPNCbKZwI2G UFAuAS0zrzduqXg7Ra4p2jqZWgzN9SK2yU1Don7qF616AXtHmZI1vc+z6WXG3Taib1KZ p1sp2y5ma0Mi/cBGJK8CyHdrHTUIvE21Px9XLewTGrbLQ1Dzcdi1z5VOoK812/VHt3a4 pCBLK+ATibFdDBGrjIyDhYGF1kwjwinbOlX4AzWJHOr8fQrZgFtRYrmaJoYRLTz4UQr5 mBKm5O4176kjMajylZUF+aZScekTXwlURv/1LwIU/ODViAUnUVMDLSwM5YsFZ7+MGLD0 Md+g== X-Forwarded-Encrypted: i=1; AJvYcCWOWbpQkaL2gWeJIC5bG44vCtqpXJHiOvbTMtfSbNDflTu9EFSEcfBV2r7j47AsY2cSlI6xE0CiN92U@lists.linux-m68k.org X-Gm-Message-State: AOJu0Yw4DsqhqyOJl90rLJY2TpMiJaHUYTD8VbomR3xd6CWwWkXryudr 5axjYrzG/1w5aLk0ZZk1PenH7m67OPYeZz2dEFTdaUwZpv+D5U1V X-Gm-Gg: ASbGnct9Mg39mGr5IHqs/+q86BpdeQuIJ8A/7ARTLMXcMRbA7SUHpcMWZxbzoXTdFeC 6bEr1h92imbtoLErnpIwfm1TC1jGHx0tjVdErK8xhYDSohSftnsMhSlJTyY9tLcMlrv4YlA+uNJ Kbr+vWeGaHtUKWu/3o3ABIXJSDQqLVve5O/HOei8aTafvJE80J5vXuHNMWwAvf7HaeILiplHf13 rx+rYne7xKfvfkKuVC4Sx2Qz1/I2OocJah0RlDzVoRDUDpYwP1ZefqqNstCJycuWM02sCX6RbAA sgiEQghQXxC2MXWqWNcqLsTARLcjptKa1mmnvgk2QvHE X-Google-Smtp-Source: AGHT+IG4Y4KdKGYoy70io/r8gYLZiFwsgOksUI+QUCeOo40CKssKjfePE5RVgUBb4ckPKQzflnN8DQ== X-Received: by 2002:a05:6a21:394b:b0:1f5:769a:a4be with SMTP id adf61e73a8af0-1fe4347101emr8883211637.36.1742581978798; Fri, 21 Mar 2025 11:32:58 -0700 (PDT) Received: from localhost ([216.228.125.130]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73906123ea2sm2382632b3a.108.2025.03.21.11.32.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Mar 2025 11:32:58 -0700 (PDT) Date: Fri, 21 Mar 2025 14:32:55 -0400 From: Yury Norov To: Tamir Duberstein Cc: David Gow , John Hubbard , Geert Uytterhoeven , Andrew Morton , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Rasmus Villemoes , Shuah Khan , Kees Cook , Muhammad Usama Anjum , linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org, linux-kselftest@vger.kernel.org, Brad Figg , David Hildenbrand , Michal Hocko , Jason Gunthorpe Subject: Re: distro support for CONFIG_KUNIT: [PATCH 0/3] bitmap: convert self-test to KUnit Message-ID: References: <20250207-bitmap-kunit-convert-v1-0-c520675343b6@gmail.com> Precedence: bulk X-Mailing-List: linux-m68k@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Mar 21, 2025 at 12:53:36PM -0400, Tamir Duberstein wrote: > Hi all, now that the printf and scanf series have been taken via kees' > tree[0] and sent in for v6.15-rc1[1], I wonder if we'd like to revisit > this discussion. > > As I understand it, the primary objections to moving bitmap to KUnit were: > - Unclear benefits. > - Source churn. > - Extra dependencies for benchmarks. > > Hopefully David's enumeration of the benefits of KUnit was compelling. > Regarding source churn: it is inevitable, but I did pay attention to > this and minimized the diff where possible. > > The last point is trickiest, because KUnit doesn't have first-class > benchmark support, but nor is there a blessed benchmark facility in > the kernel generally. I'd prefer not to tie this series to distros > enabling KUNIT_CONFIG by default, which will take $time. > > I think the most sensible thing we can do - if we accept that KUnit > has benefits to offer - is to split test_bitmap.c into > benchmark_bitmap.c and bitmap_kunit.c. > > Please let me know your thoughts. Sure, no problem. I asked you to answer to 4 very simple and specific questions. You didn't answer any of them. David sent a lengthy email that doesn't address them, either. None of you guys submitted anything to bitmaps - neither in library, nor in tests. Your opinion about what is good for bitmap development and what's not is purely theoretical. Real contributors never concerned about current testing model. I think that you don't care about bitmaps. If bitmaps testing will get broken one day, or more complicated, you will not come to help. If I'm wrong and you are willing to contribute, you're warmly welcome! I always encourage people to increase testing coverage. If you'd like to add new cases to existing tests - I'll be happy. If you'd like to add completely new tests based on KUNITs or whatever else - I'll be happy just as well. Thanks, Yury