From: Christoph Hellwig <hch@infradead.org>
To: Finn Thain <fthain@linux-m68k.org>
Cc: Michael Schmitz <schmitzmic@gmail.com>,
Martin Steigerwald <martin@lichtvoll.de>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-m68k@vger.kernel.org,
geert@linux-m68k.org, Christoph Hellwig <hch@infradead.org>,
Joanne Dow <jdow@earthlink.net>
Subject: Re: [PATCH v7 2/2] block: add overflow checks for Amiga partition support
Date: Wed, 14 Jun 2023 21:28:31 -0700 [thread overview]
Message-ID: <ZIqTb4ri+mb5JIbk@infradead.org> (raw)
In-Reply-To: <82d25ec7-47cb-cb40-c800-892af48a71f6@linux-m68k.org>
On Thu, Jun 15, 2023 at 10:13:14AM +1000, Finn Thain wrote:
> > affs_hardblocks.h is a UAPI header - what are the rules and
> > ramifications around changes to those? Might not be worth the hassle in
> > the end.
> >
>
> I think it's safe to fix the UAPI header if we are talking about
> endianness annotations that affect static checking and not code
> generation. The existing annotations in that struct would appear to
> support that notion, if indeed they were put there for the benefit of the
> kernel.
More importantly there has never been any API gurantee in the UAPI
headers. Compiling user space code absolutely may break due to changes
to them (although we avoid that if we can), we just must not change the
kernel ABI. But as as said the __be annotations are no-ops for
compilers, and do the right thing even in userspace for projects using
sparse.
prev parent reply other threads:[~2023-06-15 4:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1539570747-19906-1-git-send-email-schmitzmic@gmail.com>
[not found] ` <1539570747-19906-3-git-send-email-schmitzmic@gmail.com>
2022-07-25 12:36 ` [PATCH v7 2/2] block: add overflow checks for Amiga partition support Martin Steigerwald
2022-07-25 23:03 ` Jens Axboe
2022-07-26 1:53 ` Michael Schmitz
2022-07-26 3:40 ` Jens Axboe
2022-07-26 3:58 ` Michael Schmitz
2022-08-21 20:59 ` Martin Steigerwald
2022-08-22 5:46 ` Michael Schmitz
2022-08-22 13:57 ` Jens Axboe
2022-08-22 20:39 ` Michael Schmitz
2022-08-22 20:41 ` Jens Axboe
2022-08-22 20:56 ` Michael Schmitz
2023-06-13 7:25 ` Martin Steigerwald
2023-06-13 8:18 ` Michael Schmitz
2023-06-13 10:57 ` Martin Steigerwald
2023-06-13 22:11 ` Michael Schmitz
2023-06-14 0:07 ` Finn Thain
2023-06-14 1:20 ` Michael Schmitz
2023-06-14 7:19 ` Martin Steigerwald
2023-06-14 8:43 ` Michael Schmitz
[not found] ` <05bd2c1b-a985-d935-a955-06a048d54c18@earthlink.net>
2023-06-14 19:46 ` Michael Schmitz
2023-06-15 0:13 ` Finn Thain
2023-06-15 1:06 ` Michael Schmitz
2023-06-15 4:28 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIqTb4ri+mb5JIbk@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=fthain@linux-m68k.org \
--cc=geert@linux-m68k.org \
--cc=jdow@earthlink.net \
--cc=linux-block@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=martin@lichtvoll.de \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox