From: Finn Thain <fthain@linux-m68k.org>
To: Michael Schmitz <schmitzmic@gmail.com>
Cc: will@sowerbutts.com, linux-m68k@vger.kernel.org,
rz@linux-m68k.org, geert@linux-m68k.org
Subject: Re: [PATCH RFC v3 2/2] m68k/q40: add data_swab option for pata_falcon to byte-swap disk data
Date: Fri, 18 Aug 2023 10:36:31 +1000 (AEST) [thread overview]
Message-ID: <a5df965a-d490-bfd4-ac3d-52e52b8b2a4a@linux-m68k.org> (raw)
In-Reply-To: <46d8fe18-5d82-6dcf-3be7-ae78642ce3af@gmail.com>
On Fri, 18 Aug 2023, Michael Schmitz wrote:
> > I think the patch could be simplified by dropping the dynamic memory
> > allocation...
>
> If using a private data pointer field for an int bitmask is acceptable
> use ...
>
I thought that was implicit in Geert's response.
I used a similar technique in drivers/nubus/proc.c and it didn't bother
anyone.
> I'll see if I can find any performance impact from the additional
> swap_data flag. If there's none, your solution may be cleaner.
>
It was the maintenance impact of the extra code that motivated my
suggestion. However, by avoiding kalloc we also avoid having to
dereference the pointer in the fast path.
next prev parent reply other threads:[~2023-08-18 0:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 3:49 [PATCH RFC v3 0/2] Q40 IDE fixes Michael Schmitz
2023-08-17 3:50 ` [PATCH RFC v3 1/2] m68k/q40: fix IO base selection for Q40 in pata_falcon.c Michael Schmitz
2023-08-17 3:50 ` [PATCH RFC v3 2/2] m68k/q40: add data_swab option for pata_falcon to byte-swap disk data Michael Schmitz
2023-08-17 10:15 ` Finn Thain
2023-08-17 11:47 ` Geert Uytterhoeven
2023-08-17 19:21 ` Michael Schmitz
2023-08-17 21:28 ` Michael Schmitz
2023-08-18 14:33 ` Geert Uytterhoeven
2023-08-18 23:53 ` Finn Thain
2023-08-21 7:46 ` Geert Uytterhoeven
2023-08-21 11:08 ` Finn Thain
2023-08-21 20:36 ` Michael Schmitz
2023-08-21 23:18 ` Finn Thain
[not found] ` <F32F62FE-2A74-4648-8BF1-0D1A1E76309B@linux-m68k.org>
2023-08-17 19:07 ` Michael Schmitz
2023-08-17 19:14 ` Michael Schmitz
2023-08-18 0:36 ` Finn Thain [this message]
2023-08-17 3:56 ` [PATCH RFC v3 0/2] Q40 IDE fixes Michael Schmitz
2023-08-17 9:20 ` William R Sowerbutts
2023-08-17 20:25 ` William R Sowerbutts
2023-08-17 21:29 ` Michael Schmitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5df965a-d490-bfd4-ac3d-52e52b8b2a4a@linux-m68k.org \
--to=fthain@linux-m68k.org \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@vger.kernel.org \
--cc=rz@linux-m68k.org \
--cc=schmitzmic@gmail.com \
--cc=will@sowerbutts.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox