From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD8FE3806AC for ; Tue, 10 Feb 2026 14:50:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=172.105.4.254 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770735021; cv=none; b=o4sEC3kbXSI1GVqEs6/T3FOu0GrMtEMCpD4UdJg+8ODtEzfDtZ4H5xHYlZ4eMnLqNAslKDlePwvTVZXU9B28ETIoO1bjOK244fgY+Gr/NPK13fDJCfSA6CebKYjepsX909djqteHJ3jUf6i/EkMpMj0trr3RBvS3B84W0WS2rh8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770735021; c=relaxed/simple; bh=YqNhqDan6ig5Eg8FfWiJBfgfNLXjdOvNf1vIcFRh5H8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sDEF4aQLBY1Cr0i7uWxEPRlCQ1qwmPjipDgsipvPhF8jR9rvH5vqW4kvRPrFih1mBDMq33hlm94r9Y6wY06KzTMrWtl5Y8HOnqvH0eGY/xKe3QZxBSve0zEFQx29Aqp0L0R6RBn9+Ig3q4IFbWH1KLAcu41lrZ5zd52ZzLgLL04= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; spf=pass smtp.mailfrom=kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=W3ex2H+6; arc=none smtp.client-ip=172.105.4.254 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="W3ex2H+6" Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 9BDB860137; Tue, 10 Feb 2026 14:50:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E02CC116C6; Tue, 10 Feb 2026 14:50:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770735018; bh=YqNhqDan6ig5Eg8FfWiJBfgfNLXjdOvNf1vIcFRh5H8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W3ex2H+6njMxfdkQtt4hfXP8xNYoYvUybMgCjkdXkRHCgKGQQudxPVj6r6Yq4X87J qKQk4SPbkNxJjifgbRHYB0LIbaEKgNT1q7EAGZDodtYWpYtXt+PLTjreRRyYh0ZuB+ 0XRCg3HQoTLA4LhyIdFuLZzdVr/SSw9/Ndr1QL+8Jlw7RzN+PIW/LRCopkpQH6Rwal J24gsB2JhUZnmKMnS2yaIoTinVPtyDQgj4UHrG750qhTNlhIvb22kewZVjFgo8FCOz fm9CerA5/tgkSQquoEeuWIQfz2qcaZ22uCaDVSNGjTWlgBnoS+i6Uy7a10vU89BO1/ TkxTBVLkg+EFQ== Date: Tue, 10 Feb 2026 16:50:00 +0200 From: Mike Rapoport To: "Christophe Leroy (CS GROUP)" Cc: Andrew Morton , Andreas Larsson , Borislav Petkov , Brian Cain , Catalin Marinas , "David S. Miller" , Dave Hansen , David Hildenbrand , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , "Liam R. Howlett" , Lorenzo Stoakes , Madhavan Srinivasan , Magnus Lindholm , Matt Turner , Max Filippov , Michael Ellerman , Michal Hocko , Michal Simek , Palmer Dabbelt , Richard Weinberger , Russell King , Stafford Horne , Suren Baghdasaryan , Thomas Gleixner , Vineet Gupta , Vlastimil Babka , Will Deacon , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-mm@kvack.org, x86@kernel.org Subject: Re: [PATCH v2 2/4] mm: rename my_zero_pfn() to zero_pfn() Message-ID: References: <20260209144058.2092871-1-rppt@kernel.org> <20260209144058.2092871-3-rppt@kernel.org> <0f15b363-a5e5-4a58-89b0-13b5112772b0@kernel.org> Precedence: bulk X-Mailing-List: linux-m68k@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0f15b363-a5e5-4a58-89b0-13b5112772b0@kernel.org> On Mon, Feb 09, 2026 at 04:08:32PM +0100, Christophe Leroy (CS GROUP) wrote: > > > Le 09/02/2026 à 15:40, Mike Rapoport a écrit : > > From: "Mike Rapoport (Microsoft)" > > > > my_zero_pfn() is a silly name. > > > > Rename zero_pfn variable to zero_page_pfn and my_zero_pfn() function to > > zero_pfn(). > > > > While on it, move extern declarations of zero_page_pfn outside the > > functions that use it and add a comment about what ZERO_PAGE is. > > I guess the idea of the extern declaration being inside its only external > users was to ensure nobody would start using it directly, hence bypassing > the overloadable helpers. > > Should we at least call the variable __zero_page_pfn instead in order to > warn people that using it directly requires care ? I'd better move it back inside the helpers. > Christophe > -- Sincerely yours, Mike.