linux-m68k.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Finn Thain <fthain@linux-m68k.org>
To: Peter Zijlstra <peterz@infradead.org>, Will Deacon <will@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Boqun Feng <boqun.feng@gmail.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Mark Rutland <mark.rutland@arm.com>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	linux-m68k@vger.kernel.org, Lance Yang <lance.yang@linux.dev>
Subject: [RFC v2 2/3] atomic: Specify alignment for atomic_t and atomic64_t
Date: Sun, 14 Sep 2025 10:45:29 +1000	[thread overview]
Message-ID: <abf2bf114abfc171294895b63cd00af475350dba.1757810729.git.fthain@linux-m68k.org> (raw)
In-Reply-To: <cover.1757810729.git.fthain@linux-m68k.org>

Some recent commits incorrectly assumed 4-byte alignment of locks.
That assumption fails on Linux/m68k (and, interestingly, would have
failed on Linux/cris also). Specify the minimum alignment of atomic
variables for fewer surprises and (hopefully) better performance.

Consistent with i386, atomic64_t is not given natural alignment here.

Cc: Lance Yang <lance.yang@linux.dev>
Link: https://lore.kernel.org/lkml/CAMuHMdW7Ab13DdGs2acMQcix5ObJK0O2dG_Fxzr8_g58Rc1_0g@mail.gmail.com/
---
Changed since v1:
 - atomic64_t now gets an __aligned attribute too.
 - The 'Fixes' tag has been dropped because Lance sent a different fix
   for commit e711faaafbe5 ("hung_task: replace blocker_mutex with encoded
   blocker") that's suitable for -stable.
---
 include/asm-generic/atomic64.h | 2 +-
 include/linux/types.h          | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/asm-generic/atomic64.h b/include/asm-generic/atomic64.h
index 100d24b02e52..7ae82ac17645 100644
--- a/include/asm-generic/atomic64.h
+++ b/include/asm-generic/atomic64.h
@@ -10,7 +10,7 @@
 #include <linux/types.h>
 
 typedef struct {
-	s64 counter;
+	s64 counter __aligned(sizeof(long));
 } atomic64_t;
 
 #define ATOMIC64_INIT(i)	{ (i) }
diff --git a/include/linux/types.h b/include/linux/types.h
index 6dfdb8e8e4c3..cd5b2b0f4b02 100644
--- a/include/linux/types.h
+++ b/include/linux/types.h
@@ -179,7 +179,7 @@ typedef phys_addr_t resource_size_t;
 typedef unsigned long irq_hw_number_t;
 
 typedef struct {
-	int counter;
+	int counter __aligned(sizeof(int));
 } atomic_t;
 
 #define ATOMIC_INIT(i) { (i) }
-- 
2.49.1


  parent reply	other threads:[~2025-09-14  0:59 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-14  0:45 [RFC v2 0/3] Align atomic storage Finn Thain
2025-09-14  0:45 ` [RFC v2 3/3] atomic: Add alignment check to instrumented atomic operations Finn Thain
2025-09-15  8:00   ` Peter Zijlstra
2025-09-15  9:38     ` Finn Thain
2025-09-15 10:06       ` Peter Zijlstra
2025-09-15 10:37         ` Finn Thain
2025-09-15 11:20           ` Arnd Bergmann
2025-09-16  0:16             ` Finn Thain
2025-09-16 10:10               ` Geert Uytterhoeven
2025-09-17  1:23                 ` Finn Thain
2025-09-16 12:37               ` Arnd Bergmann
2025-09-16 21:38                 ` Brad Boyer
2025-09-17 16:54                   ` Andreas Schwab
2025-09-17  2:14                 ` Finn Thain
2025-09-22 15:49                   ` Arnd Bergmann
2025-09-23  6:39                     ` Finn Thain
2025-09-14  0:45 ` [RFC v2 1/3] documentation: Discourage alignment assumptions Finn Thain
2025-09-14  0:45 ` Finn Thain [this message]
2025-09-15  7:13   ` [RFC v2 2/3] atomic: Specify alignment for atomic_t and atomic64_t Geert Uytterhoeven
2025-09-15  7:35   ` Arnd Bergmann
2025-09-15  8:06     ` Peter Zijlstra
2025-09-15  9:26     ` Finn Thain
2025-09-15  9:29       ` Arnd Bergmann
2025-09-22  7:06   ` Geert Uytterhoeven
2025-09-22  8:16     ` Finn Thain
2025-09-22  9:29       ` Geert Uytterhoeven
2025-09-22 15:21       ` Arnd Bergmann
2025-09-23  6:28         ` Finn Thain
2025-09-23  6:41           ` Arnd Bergmann
2025-09-23  8:05             ` Finn Thain
2025-09-23 19:11               ` Arnd Bergmann
2025-09-30  2:18           ` Finn Thain
2025-09-30  6:35             ` Arnd Bergmann
2025-10-01  1:03               ` Finn Thain
2025-10-01  6:44                 ` Arnd Bergmann
2025-10-06  9:25                   ` Finn Thain
2025-10-06  9:25               ` Finn Thain
2025-10-06 10:07                 ` Arnd Bergmann
2025-10-06 10:22                   ` Peter Zijlstra
2025-10-06 11:09                     ` Arnd Bergmann
2025-10-06  9:37               ` Peter Zijlstra
2025-09-30  7:41             ` Geert Uytterhoeven
2025-10-01  1:46               ` Finn Thain
2025-10-01  7:08                 ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abf2bf114abfc171294895b63cd00af475350dba.1757810729.git.fthain@linux-m68k.org \
    --to=fthain@linux-m68k.org \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=boqun.feng@gmail.com \
    --cc=corbet@lwn.net \
    --cc=geert@linux-m68k.org \
    --cc=lance.yang@linux.dev \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=peterz@infradead.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).