From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA13FC433FE for ; Fri, 10 Dec 2021 18:16:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241915AbhLJSTj (ORCPT ); Fri, 10 Dec 2021 13:19:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236861AbhLJSTg (ORCPT ); Fri, 10 Dec 2021 13:19:36 -0500 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FB61C0617A1 for ; Fri, 10 Dec 2021 10:16:01 -0800 (PST) Received: by mail-lf1-x136.google.com with SMTP id b1so19447715lfs.13 for ; Fri, 10 Dec 2021 10:16:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=bcvtGiLbR5hJWeiVCch89vaOnPBEjfgkGhnDVgGToIE=; b=G0qTQ3KGFrwps8qADsCL0qK6agYLp7ivalOB/mF7ukTMqKqODRUNPClBA+tjj958iZ zDP5ALcBXKrVg0xx9H2ws3hyb3r6CIVdqsbS/GVCsvrWbnNO0HGlLBE864udH5VLQpzA E4ZCGQvWrQ3sm3YxkToWB7AGuZSE/qHZ86M8KsEpcZTMCU4IFoRlulk9U2f7fjt0DgcE dievaYp3/3GIUU6nMVScS6FhLqdlOsaTCJ8+eRNM/gp2aIGsGid35kag1Oq9XwyLJEZe Lsdj6NoONSIfbrp21Zrfz1ZI08pSDTMKtV8ZG3ySXOqe/j3lBC+KMsiD//GTJ5tyuvfx eTTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bcvtGiLbR5hJWeiVCch89vaOnPBEjfgkGhnDVgGToIE=; b=sTFeEv9YPemBNVsuX9M+2GhX6xs52EQFDGxzzf4AVLwwKTalWH+ro0LA9bDdClK90h MuWYiF1h1xJPThjNF5ow09+IQIBaMPZ11785KsTO+J4p8zeYVLAD4SMMd3AbYm3tT30H +d+aau4VmiYGzoxHcwttkXaUZuEJkJ7/6ubxwdHRqQaSrlMAaPT9DlKf46GuNHf9733j JpSx43v4UEjEE7A9/xOAeLeYC18yJoLDsXPEjp6YbJnkK59YLRO5fWq6Sq9M7p83VN2X vymRxB8rxAbdUa9ormlPcuY0qagiCAqpgc8tAEmlLpArSahU6o2MMwQjfgMuv+XoWJ/j vJiA== X-Gm-Message-State: AOAM533frlDB2CaOmJb8dk1lx+C/T/5PQMmPt9mcvexkbZqm/CIQMaKD h8S6NcSsQB58nytGyEHIRks= X-Google-Smtp-Source: ABdhPJwR/4XeF0n78EyaU8daj5gqPU1YI5WhyixXiCZ/1XxnYO6fYoSxPShwkvEp5UZp5BYd303wDQ== X-Received: by 2002:a05:6512:40b:: with SMTP id u11mr13847699lfk.377.1639160159550; Fri, 10 Dec 2021 10:15:59 -0800 (PST) Received: from [192.168.2.145] (94-29-46-111.dynamic.spd-mgts.ru. [94.29.46.111]) by smtp.googlemail.com with ESMTPSA id q15sm379095lfp.32.2021.12.10.10.15.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Dec 2021 10:15:59 -0800 (PST) Subject: Re: [PATCH v4 07/25] reboot: Remove extern annotation from function prototypes To: "Rafael J. Wysocki" Cc: Thierry Reding , Jonathan Hunter , Russell King , Catalin Marinas , Will Deacon , Guo Ren , Geert Uytterhoeven , Greg Ungerer , Joshua Thompson , Thomas Bogendoerfer , Sebastian Reichel , Linus Walleij , Philipp Zabel , Greentime Hu , Vincent Chen , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Yoshinori Sato , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , the arch/x86 maintainers , "H. Peter Anvin" , Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Len Brown , Santosh Shilimkar , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Pavel Machek , Lee Jones , Andrew Morton , Guenter Roeck , Daniel Lezcano , Andy Shevchenko , Ulf Hansson , alankao@andestech.com, "K . C . Kuen-Chern Lin" , Linux ARM , Linux Kernel Mailing List , linux-csky@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev , linux-riscv@lists.infradead.org, Linux-sh list , xen-devel@lists.xenproject.org, ACPI Devel Maling List , Linux PM , linux-tegra References: <20211126180101.27818-1-digetx@gmail.com> <20211126180101.27818-8-digetx@gmail.com> From: Dmitry Osipenko Message-ID: Date: Fri, 10 Dec 2021 21:15:57 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-m68k@vger.kernel.org 10.12.2021 21:09, Rafael J. Wysocki пишет: > On Fri, Nov 26, 2021 at 7:02 PM Dmitry Osipenko wrote: >> >> There is no need to annotate function prototypes with 'extern', it makes >> code less readable. Remove unnecessary annotations from . >> >> Signed-off-by: Dmitry Osipenko > > I'm not sure that this is really useful. > > Personally, I tend to respect the existing conventions like this. > > Surely, this change is not required for the rest of the series to work. Problem that such things start to spread all over the kernel with a copy-paste approach if there is nobody to clean up the code. This is not a common convention and sometimes it's getting corrected [1]. [1] https://git.kernel.org/linus/6d7434931