Re: [PATCH v9] kallsyms: Add self-test facility

Andreas Schwab
2022-12-16T11:53:10Z

On Dez 15 2022, Geert Uytterhoeven wrote:

> Changing:
>
> --- a/arch/m68k/include/asm/string.h
> +++ b/arch/m68k/include/asm/string.h
> @@ -42,7 +42,7 @@ static inline char *strncpy(char *dest, const
> char *src, size_t n)
> #define __HAVE_ARCH_STRCMP
> static inline int strcmp(const char *cs, const char *ct)
> {
> - char res;
> + signed char res;
>
> asm ("\n"
> "1: move.b (%0)+,%2\n" /* get *cs */

Note that strcmp needs to compute the return value from the difference
of the _unsigned_ characters. That does not explain the error, though,
since symbol names don't have characters with the high bit set.

--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."