From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
hch@infradead.org, akpm@linux-foundation.org,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-m68k@lists.linux-m68k.org
Subject: Re: [RFC V1 08/31] m68k/mm: Enable ARCH_HAS_VM_GET_PAGE_PROT
Date: Tue, 25 Jan 2022 09:12:04 +0530 [thread overview]
Message-ID: <aef5318e-0b48-2a9e-1a1b-386894b116f4@arm.com> (raw)
In-Reply-To: <87mtjl8bnl.fsf@igel.home>
On 1/24/22 7:43 PM, Andreas Schwab wrote:
> On Jan 24 2022, Anshuman Khandual wrote:
>
>> +pgprot_t vm_get_page_prot(unsigned long vm_flags)
>> +{
>> + switch (vm_flags & (VM_READ | VM_WRITE | VM_EXEC | VM_SHARED)) {
>> + case VM_NONE:
>> + return __pgprot(pgprot_val(PAGE_NONE_C)|_PAGE_CACHE040);
>
> _PAGE_CACHE040 should only be present when running on a 040 or 060.
>
Right, seems like I have missed the conditionality on CPU_IS_040_OR_060
while moving the code, will fix it.
prev parent reply other threads:[~2022-01-25 7:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1643029028-12710-1-git-send-email-anshuman.khandual@arm.com>
2022-01-24 12:56 ` [RFC V1 08/31] m68k/mm: Enable ARCH_HAS_VM_GET_PAGE_PROT Anshuman Khandual
2022-01-24 14:13 ` Andreas Schwab
2022-01-25 3:42 ` Anshuman Khandual [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aef5318e-0b48-2a9e-1a1b-386894b116f4@arm.com \
--to=anshuman.khandual@arm.com \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mm@kvack.org \
--cc=schwab@linux-m68k.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox