public inbox for linux-m68k@lists.linux-m68k.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Angelo Dureghello <angelo@kernel-space.org>
Cc: "Greg Ungerer" <gerg@linux-m68k.org>,
	"Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Steven King" <sfking@fdwdc.com>, "Arnd Bergmann" <arnd@arndb.de>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Greg Ungerer" <gerg@uclinux.org>,
	linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org,
	"Angelo Dureghello" <adureghello@baylibre.com>
Subject: Re: [PATCH 08/10] m68k: stmark2: add mcf5441x DAC platform devices
Date: Tue, 5 May 2026 11:31:39 +0300	[thread overview]
Message-ID: <afmq6-AfomfKtX7c@ashevche-desk.local> (raw)
In-Reply-To: <20260504-wip-stmark2-dac-v1-8-874c36a4910d@baylibre.com>

On Mon, May 04, 2026 at 07:16:46PM +0200, Angelo Dureghello wrote:

> Add mcf5441x DAC platform devices.

...

> +static struct resource dspi_dac0_resource[] = {
> +	[0] = {
> +		.start = MCFDAC_BASE0,
> +		.end   = MCFDAC_BASE0 + 0xFF,
> +		.flags = IORESOURCE_MEM,
> +	},
> +};

ioport.h has a lot of DEFINE_RES() macros. Please, choose the best fit in each
case and use them.

-- 
With Best Regards,
Andy Shevchenko



  parent reply	other threads:[~2026-05-05  8:31 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-04 17:16 [PATCH 00/10] add mcf54415 DAC driver Angelo Dureghello
2026-05-04 17:16 ` [PATCH 01/10] m68k: mcf5441x: fix clocks numbering Angelo Dureghello
2026-05-04 17:16 ` [PATCH 02/10] m68k: mcf5441x: add clock for DAC channel 1 Angelo Dureghello
2026-05-04 17:16 ` [PATCH 03/10] m68k: mcf5441x: setup DAC clock name as per driver name Angelo Dureghello
2026-05-04 17:16 ` [PATCH 04/10] m68k: defconfig: update stmark2 defconfig Angelo Dureghello
2026-05-04 17:16 ` [PATCH 05/10] m68k: add DAC modules base addresses Angelo Dureghello
2026-05-04 17:16 ` [PATCH 06/10] m68k: mcf5441x: add CCM registers Angelo Dureghello
2026-05-04 17:16 ` [PATCH 07/10] m68k: mcf5441x: add CCR MISCCR2 bitfields Angelo Dureghello
2026-05-04 17:16 ` [PATCH 08/10] m68k: stmark2: add mcf5441x DAC platform devices Angelo Dureghello
2026-05-04 17:28   ` Arnd Bergmann
2026-05-05  8:31   ` Andy Shevchenko [this message]
2026-05-04 17:16 ` [PATCH 09/10] m68k: stmark2: enable DACs outputs Angelo Dureghello
2026-05-05  2:12   ` Greg Ungerer
2026-05-05  8:32   ` Andy Shevchenko
2026-05-04 17:16 ` [PATCH 10/10] iio: dac: add mcf54415 DAC Angelo Dureghello
2026-05-04 17:27   ` Arnd Bergmann
2026-05-05  2:06     ` Greg Ungerer
2026-05-05  5:54       ` Angelo Dureghello
2026-05-04 19:13   ` Nuno Sá
2026-05-05  8:45   ` Andy Shevchenko
2026-05-04 19:57 ` [PATCH 00/10] add mcf54415 DAC driver Angelo Dureghello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afmq6-AfomfKtX7c@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=adureghello@baylibre.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andy@kernel.org \
    --cc=angelo@kernel-space.org \
    --cc=arnd@arndb.de \
    --cc=dlechner@baylibre.com \
    --cc=geert@linux-m68k.org \
    --cc=gerg@linux-m68k.org \
    --cc=gerg@uclinux.org \
    --cc=jic23@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=nuno.sa@analog.com \
    --cc=sfking@fdwdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox