Re: [PATCH] m68k/kernel - wire up syscall_trace_enter/leave for m68k

John Paul Adrian Glaubitz
2020-08-26T12:35:35Z

Hi Geert!

On 8/26/20 2:32 PM, Geert Uytterhoeven wrote:
>  #include <linux/uaccess.h>
>  #include <asm/page.h>
> @@ -277,6 +278,9 @@ asmlinkage int syscall_trace_enter(void)
>
>      if (test_thread_flag(TIF_SYSCALL_TRACE))
>          ret = tracehook_report_syscall_entry(task_pt_regs(current));
> +
> +    secure_computing_strict(task_pt_regs(current)->orig_d0);
> +

That part is outdated. It was removed in the second commit I posted, see:

> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/sh?id=0bb605c2c7f2b4b314b91510810b226de7f34fa1

Do you have the check of the return value already in syscall_trace_entry?

It should check for "-1" and jump to syscall_exit if true.

Adrian

--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaubitz@debian.org
`. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913