Re: [PATCH] m68k/kernel - wire up syscall_trace_enter/leave for m68k

John Paul Adrian Glaubitz
2020-08-26T12:42:21Z

Hi Geert!

On 8/26/20 2:38 PM, Geert Uytterhoeven wrote:
>> That part is outdated. It was removed in the second commit I posted, see:
>>
>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/sh?id=0bb605c2c7f2b4b314b91510810b226de7f34fa1
>
> That's the part which adds seccomp filter support.
>
>> Do you have the check of the return value already in syscall_trace_entry?
>>
>> It should check for "-1" and jump to syscall_exit if true.
>
> No, as that's needed only for seccomp filter support, AFAIU.
>
> Have a look at arm, where seccomp filter support is optional, depending on ABI.

As far as I know, filter support is mandatory these days. At least for SH, libseccomp
sent me away with my PR and told me to come back until the kernel has filter support.

Maybe I'm missing something but let's put Michael Karcher in the loop, he knows better
as he helped me with the kernel parts of SECCOMP on SH.

Adrian

--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaubitz@debian.org
`. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913