From: Finn Thain <fthain@telegraphics.com.au>
To: schmitz <schmitz@biophys.uni-duesseldorf.de>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Linux/m68k <linux-m68k@vger.kernel.org>
Subject: Re: m68k-queue
Date: Wed, 15 May 2013 18:47:39 +1000 (EST) [thread overview]
Message-ID: <alpine.LNX.2.00.1305151727470.10554@nippy.intranet> (raw)
In-Reply-To: <5191FC4C.8010707@biophys.uni-duesseldorf.de>
On Tue, 14 May 2013, schmitz wrote:
> > - mac: ADB raw packets
> > I guess this can be dropped?
Geert, you should drop this patch, because there are no other patches in
your queue that use ADBREQ_RAW and because it seems to be broken (the idea
of sending a raw packet using adb_request() was apparently to permit
req->data[0] != ADB_PACKET). Also it seems to have become obsolete back in
2006.
>
> I'd guess so - I struggle to recall what this was for. Perhaps to talk
> to the clock chip on some Macs.
I went digging in the mac68k repo. ADBREQ_RAW shows up here:
"Latest ADB changes including the new 68k PMU driver."
http://linux-mac68k.cvs.sourceforge.net/viewvc/linux-mac68k/linux-mac68k/drivers/macintosh/adb.c?r1=1.15&r2=1.16&
"Added Baboon interrupt support.
Moved all time and PRAM-related functions into misc.c."
http://linux-mac68k.cvs.sourceforge.net/viewvc/linux-mac68k/linux-mac68k/arch/m68k/mac/misc.c?r1=1.4&r2=1.5&
You are right, ADBREQ_RAW was clearly PRAM and clock related.
And this seems to indicate roughly when it got broken:
"Merge with 2.4.0 release."
http://linux-mac68k.cvs.sourceforge.net/viewvc/linux-mac68k/linux-mac68k/drivers/macintosh/adb.c?r1=1.21&r2=1.22
Anyway, in mainline kernels, adb_request() was not called from the PRAM
and clock related code since 2006 when Al Viro got that code to build
again:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/arch/m68k/mac/misc.c?id=3272244c2b1a8f13cec83c04b8245fa7fcb47a27
Finn
next prev parent reply other threads:[~2013-05-15 8:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 9:56 m68k-queue Geert Uytterhoeven
2013-05-14 8:56 ` m68k-queue schmitz
2013-05-15 5:45 ` m68k-queue Brad Boyer
2013-05-15 6:53 ` m68k-queue Geert Uytterhoeven
2013-05-18 7:09 ` m68k-queue Brad Boyer
2013-05-18 8:38 ` m68k-queue schmitz
2013-05-18 17:53 ` m68k-queue Brad Boyer
2013-05-15 8:47 ` Finn Thain [this message]
2013-05-15 22:10 ` m68k-queue Michael Schmitz
2013-05-16 2:55 ` m68k-queue Finn Thain
2013-05-16 22:40 ` m68k-queue Michael Schmitz
2013-05-18 1:48 ` m68k-queue Finn Thain
2013-05-18 5:53 ` m68k-queue Michael Schmitz
2013-05-18 6:28 ` m68k-queue Andreas Schwab
2013-05-18 7:03 ` m68k-queue Geert Uytterhoeven
2013-05-18 7:50 ` m68k-queue Brad Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1305151727470.10554@nippy.intranet \
--to=fthain@telegraphics.com.au \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@vger.kernel.org \
--cc=schmitz@biophys.uni-duesseldorf.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox