From: Finn Thain <fthain@telegraphics.com.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] m68k/mac: Allocate IOP message pool and queues dynamically
Date: Mon, 1 Jul 2013 17:46:48 +1000 (EST) [thread overview]
Message-ID: <alpine.LNX.2.00.1307011325520.9968@nippy.intranet> (raw)
In-Reply-To: <1372586542-1318-1-git-send-email-geert@linux-m68k.org>
On Sun, 30 Jun 2013, Geert Uytterhoeven wrote:
> +static void __init alloc_msg_queue(int iop_num)
> +{
> + iop_send_queue[iop_num] =
> + kzalloc(NUM_IOP_CHAN * sizeof(**iop_send_queue), GFP_KERNEL);
> + iop_listeners[iop_num] =
> + kzalloc(NUM_IOP_CHAN * sizeof(**iop_listeners), GFP_KERNEL);
Perhaps we should panic on allocation failure? It might upset the static
checkers otherwise. Can be done in another patch I guess.
> -
> -/*
> - * Register the interrupt handler for the IOPs.
> - * TODO: might be wrong for non-OSS machines. Anyone?
> - */
> -
> -void __init iop_register_interrupts(void)
> -{
> - if (iop_ism_present) {
> + /*
> + * Register the interrupt handler for the IOPs.
> + * TODO: might be wrong for non-OSS machines. Anyone?
My testing with a non-OSS machine (Quadra 950) indicates that the TODO is
obsolete. And the comment "register the interrupt handler for the IOPs" is
a bit silly. It merely re-phrases the code. Otherwise, this patch looks
good to me. Thanks.
Finn
next prev parent reply other threads:[~2013-07-01 7:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-30 10:02 [PATCH] m68k/mac: Allocate IOP message pool and queues dynamically Geert Uytterhoeven
2013-07-01 6:52 ` Brad Boyer
2013-07-01 7:48 ` Finn Thain
2013-07-01 22:48 ` Brad Boyer
2013-07-01 7:46 ` Finn Thain [this message]
2013-07-01 21:59 ` Brad Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1307011325520.9968@nippy.intranet \
--to=fthain@telegraphics.com.au \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox