Re: [PATCH 2/3] m68k: Switch to asm-generic/barrier.h

Finn Thain
2014-02-05T01:03:05Z

On Tue, 4 Feb 2014, Geert Uytterhoeven wrote:

> The generic nop() implementation is fine for m68k.
>

If the barrier in the old nop() implementation isn't needed anymore,
perhaps we should also remove the nop() instances in macfb.c? One comment
from this file says, "the nop's are there to order writes". (I don't know
whether there is any timing issue here. Seeing the way nop() was sprinkled
through macfb.c, I doubt that there is.) Is the volatile casting in
nubus_writeb() aka raw_outb() aka out_8() equivalent to the old barrier?

Finn