From mboxrd@z Thu Jan 1 00:00:00 1970 From: Finn Thain Subject: Re: [PATCH v2 30/36] atari_NCR5380: Merge from sun3_NCR5380.c Date: Fri, 31 Oct 2014 23:48:54 +1100 (AEDT) Message-ID: References: <20141027052607.105914311@telegraphics.com.au> <20141027052614.365442007@telegraphics.com.au> <5451F7F6.3020704@suse.de> <54534B07.5080302@suse.de> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from kvm5.telegraphics.com.au ([98.124.60.144]:58299 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758408AbaJaMt5 (ORCPT ); Fri, 31 Oct 2014 08:49:57 -0400 In-Reply-To: <54534B07.5080302@suse.de> Sender: linux-m68k-owner@vger.kernel.org List-Id: linux-m68k@vger.kernel.org To: Sam Creasey , Hannes Reinecke Cc: "James E.J. Bottomley" , Michael Schmitz , linux-scsi@vger.kernel.org, linux-m68k@vger.kernel.org On Fri, 31 Oct 2014, Hannes Reinecke wrote: > Hmm. I always feel a bit awkward by using personal names in the code. > It's not good practice nowadays. Plus one can never be sure if that > address is still valid. Or remains so for the foreseeable future. It was valid as of a couple of months ago. > > But hey, these are just my personal opinions. I agree with your opinions and I'm not entirely happy with this patch either. But I don't know what to do about it. --