Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380 drivers

Christoph Hellwig
2015-11-20T11:45:15Z

On Fri, Nov 20, 2015 at 12:40:03PM +0100, Ondrej Zary wrote:
> > > I'd love to be able to get rid of the ISA drivers to be honest.
> >
> > Is that because of their use of scsi_module.c or their general decrepitude
> > or something else?
>
> scsi_module.c usage shouldn't be hard to fix. I can do that after finding a working setup.

It's the general state of them.

>
> > > Given that they appear to be gravely broken before your cleanups this
> > > might be an opportunity to get rid of them.
> >
> > At this stage, that's unclear (to me). It could be that g_NCR5380.c is not
> > broken. It could be that the core driver can't handle certain targets. I
> > think we need to do more testing.
>
> Maybe I was just unlucky and tested a drive that never worked with this driver.
>
> Working ISA means more testing possibilities. It's much easier to get an ISA card than a Sun or Atari. Also faster CPU (such as 1 GHz P3) means quicker testing.

Well, if you volunteer to bring the NCR5380 ISA drivers up to date and
maintain them it's obvuously fine to keep them around.

I'm more worried about all the unmaintained ISA drivers in horrible
shape.