Re: [PATCH 00/71] More fixes, cleanup and modernization for NCR5380 drivers

Finn Thain
2015-11-20T08:19:21Z

On Thu, 19 Nov 2015, Christoph Hellwig wrote:

> On Fri, Nov 20, 2015 at 06:21:06PM +1100, Finn Thain wrote:
>
> > > Not sure what module was being probed here. I presume it was
> > > g_NCR5380 or g_NCR5380_mmio. Neither of these calls
> > > 'scsi_scan_host'. I'm not sure what the implications are (?)
> >
> > Nevermind. The call is in scsi_module.c.
>
> Which, btw really need to go away. If you want to resurrect the
> ISA drivers they need to be converted to proper probing.

Yes. I didn't do that conversion because I don't have ISA hardware and I
don't understand ISA probing.

The present patch set doesn't seek to resurrect the ISA drivers. But I am
trying to avoid regressions.

I have mixed feelings about the ISA drivers. ISA DMA support complicates
things (it was never completed) and DMA seems to be the main obstacle to
merging the two core driver forks.

--