Re: [PATCH v3 26/77] ncr5380: Fix NCR5380_transfer_pio() result

Hannes Reinecke
2015-12-22T07:22:40Z

On 12/22/2015 02:18 AM, Finn Thain wrote:
> According to the SCSI-2 draft revision 10L, atari_NCR5380.c is correct
> when it says that the phase lines are valid up until ACK is negated
> following the transmission of the last byte in MESSAGE IN phase. This is
> true for all information transfer phases, from target to initiator.
>
> Sample the phase bits in STATUS_REG so that NCR5380_transfer_pio() can
> return the correct result. The return value is presently unused (perhaps
> because of bugs like this) but this change at least fixes the caller's
> phase variable, which is passed by reference.
>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
>
> ---
> drivers/scsi/NCR5380.c | 12 +++++++++---
> drivers/scsi/atari_NCR5380.c | 11 ++++++-----
> 2 files changed, 15 insertions(+), 8 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)