From: Finn Thain <fthain@telegraphics.com.au>
To: afzal mohammed <afzal.mohd.ma@gmail.com>
Cc: linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org,
Greg Ungerer <gerg@linux-m68k.org>,
Thomas Gleixner <tglx@linutronix.de>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH v2 06/18] m68k: Replace setup_irq() by request_irq()
Date: Sun, 1 Mar 2020 14:26:33 +1100 (AEDT) [thread overview]
Message-ID: <alpine.LNX.2.22.394.2003011337590.15@nippy.intranet> (raw)
In-Reply-To: <20200301010511.GA5195@afzalpc>
On Sun, 1 Mar 2020, afzal mohammed wrote:
> On Sun, Mar 01, 2020 at 10:11:51AM +1100, Finn Thain wrote:
> > On Sat, 29 Feb 2020, afzal mohammed wrote:
>
> > > [...]
> > > Specific to m68k, following changes has been made based on m68 family
> > > ;) feedback,
> > >
> >
> > None of my comments were specific to any architecture.
>
> One thing i had in my background, but realize now that didn't express
> anywhere in my mails, in essence what Geert mentioned, i.e. being legacy
> code, i did not give a treatment that would have been given to adding
> new code.
>
> But m68k subthread has been a very lively one and as not many changes,
> felt it was not fair from my side not to handle almost as though it is a
> new code addition.
>
I took Geert's comments to be architecture agnostic but perhaps I
misunderstood.
BTW, how do you distinguish between "new code" and "legacy code"?
And why would you choose to do that when you are writing a tree-wide
semantic patch?
next prev parent reply other threads:[~2020-03-01 3:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 0:47 [PATCH v2 00/18] genirq: Remove setup_irq() afzal mohammed
2020-02-24 0:50 ` [PATCH v2 06/18] m68k: Replace setup_irq() by request_irq() afzal mohammed
2020-02-26 0:42 ` Greg Ungerer
2020-02-26 1:11 ` Finn Thain
2020-02-26 2:11 ` Greg Ungerer
2020-02-26 6:39 ` Finn Thain
2020-02-26 12:26 ` Greg Ungerer
2020-02-26 22:31 ` Finn Thain
2020-02-27 6:37 ` Greg Ungerer
2020-02-27 22:19 ` Finn Thain
2020-02-27 8:18 ` afzal mohammed
2020-02-27 8:32 ` Geert Uytterhoeven
2020-02-27 12:06 ` afzal mohammed
2020-02-27 22:38 ` Finn Thain
2020-02-29 12:41 ` afzal mohammed
2020-02-28 7:05 ` Greg Ungerer
2020-02-29 12:47 ` afzal mohammed
2020-02-29 13:15 ` afzal mohammed
2020-02-29 23:11 ` Finn Thain
2020-03-01 1:05 ` afzal mohammed
2020-03-01 3:26 ` Finn Thain [this message]
2020-03-01 6:13 ` afzal mohammed
2020-03-02 6:26 ` Finn Thain
2020-03-04 1:24 ` afzal mohammed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.22.394.2003011337590.15@nippy.intranet \
--to=fthain@telegraphics.com.au \
--cc=afzal.mohd.ma@gmail.com \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox