From: Finn Thain <fthain@telegraphics.com.au>
To: "David D. Kilzer" <ddkilzer@kilzer.net>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
linux-fbdev-devel@lists.sourceforge.net,
linux-m68k@vger.kernel.org
Subject: Re: [PATCH 8/13] fbdev: mac_var_to_mode() fix
Date: Wed, 4 Nov 2009 11:48:36 +1100 (EST) [thread overview]
Message-ID: <alpine.OSX.2.00.0911041052180.369@silk.local> (raw)
In-Reply-To: <282725.7401.qm@web110813.mail.gq1.yahoo.com>
On Tue, 3 Nov 2009, David D. Kilzer wrote:
> On Tue, November 3, 2009 at 5:43:16 AM, Finn Thain wrote:
>
> > /* 800x600 */
> > + { VMODE_800_600_56, &mac_modedb[2] },
> > + { VMODE_800_600_60, &mac_modedb[3] },
> > { VMODE_800_600_75, &mac_modedb[5] },
> > { VMODE_800_600_72, &mac_modedb[4] },
> > - { VMODE_800_600_60, &mac_modedb[3] },
> > - { VMODE_800_600_56, &mac_modedb[2] },
>
>
> I believe you want to swap VMODE_800_600_75 and VMODE_800_600_72 here as well.
In this case, the mode with the faster vertical refresh frequency actually
has the higher pixel clock period. So I think the patch is correct.
Finn
>
> Dave
>
prev parent reply other threads:[~2009-11-04 0:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 13:43 [PATCH 8/13] fbdev: mac_var_to_mode() fix Finn Thain
2009-11-03 17:00 ` David D. Kilzer
2009-11-04 0:48 ` Finn Thain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.OSX.2.00.0911041052180.369@silk.local \
--to=fthain@telegraphics.com.au \
--cc=ddkilzer@kilzer.net \
--cc=geert@linux-m68k.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-m68k@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox