Re: [PATCH 1/1] m68k: add missing I/O macros {in,out}{w,l}_p() for !CONFIG_ISA

Michael Schmitz
2010-10-04T07:57:39Z

Hi,

please take care not to disturb these macros for any other case than
the default one (nothing related to ISA emulation configured at all).

Are you certain the speakup driver has a chance to work, once you got
it to compile?

Cheers,

Michael

On Sun, Oct 3, 2010 at 8:48 PM, Thorsten Glaser <tg@debian.org> wrote:
> On m68k, I/O macros like inb() outw() etc. are only defined to
> something useful if CONFIG_ISA is set; dummies are in place if
> not, but four macros were missing from the !CONFIG_ISA case.
> Adding these makes some drivers, such as speakup, compile again.
> The patch was made against Debian’s linux-2.6_2.6.32-24, but
> applies cleanly on linux-m68k master.
>
> Signed-off-by: Thorsten Glaser <tg@debian.org>
> ---
>  arch/m68k/include/asm/io_mm.h |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/arch/m68k/include/asm/io_mm.h b/arch/m68k/include/asm/io_mm.h
> index 56a6555..be9d7da 100644
> --- a/arch/m68k/include/asm/io_mm.h
> +++ b/arch/m68k/include/asm/io_mm.h
> @@ -387,9 +387,13 @@ static inline void isa_delay(void)
>  #define outb(val,port)     ((void)0)
>  #define outb_p(val,port)   ((void)0)
>  #define inw(port)          0xffff
> +#define inw_p(port)        0xffff
>  #define outw(val,port)     ((void)0)
> +#define outw_p(val,port)   ((void)0)
>  #define inl(port)          0xffffffffUL
> +#define inl_p(port)        0xffffffffUL
>  #define outl(val,port)     ((void)0)
> +#define outl_p(val,port)   ((void)0)
>
>  #define insb(port,buf,nr)  ((void)0)
>  #define outsb(port,buf,nr) ((void)0)
> --
> 1.6.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>