Re: [PATCH 1/1] m68k: add missing I/O macros {in,out}{w,l}_p() for !CONFIG_ISA

Finn Thain
2010-10-04T10:51:20Z

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1283 bytes --]

On Mon, 4 Oct 2010, Thorsten Glaser wrote:

> Finn Thain dixit:
>
> Besides, this seems like a simple fix or an accidental omission to me.
> What is with all this bikeshedding?

It isn't bikeshedding. Recall that I built these sources a few weeks ago
when you mentioned the speakup issue in private correspondence. At the
time, I built speakup in 2.6.32-23 to see if it would behave differently
than the 2.6.3[45] sources that were giving you grief.

It built for me at the time, so I was suprised to find out it didn't build
for you, and naturally I wanted to know what I did wrong.

It may be that speakup works on amiga and atari (I don't know). It doesn't
work on mac as there are no audio drivers. It has long frustrated me that
there is bloat in the debian kernel configs. So perhaps I am guilty of
being unfairly obstructionist here, in the hope that the config file
issues could be addressed. My apologies.

> Some macros are not available on m68k if CONFIG_ISA is not set, but they
> are available “almost” or even really everywhere else, so drivers use
> them, so m68k is buggy in not providing them. (Outsider’s PoV.)

You may be right. I confess to being ignorant when it comes to ISA.

Finn

>
> bye,
> //mirabilos
>