Re: [PATCH 1/1] m68k: add missing I/O macros {in,out}{w,l}_p() for !CONFIG_ISA

Geert Uytterhoeven
2010-10-04T13:18:12Z

On Mon, Oct 4, 2010 at 12:22, Finn Thain <fthain@telegraphics.com.au> wrote:
> It builds for me if I disable CONFIG_SPEAKUP. Otherwise, I get:
>
> drivers/staging/speakup/speakup_dtlk.c: In function 'synth_probe':
> drivers/staging/speakup/speakup_dtlk.c:339: error: implicit declaration of function 'inw_p'
> make[3]: *** [drivers/staging/speakup/speakup_dtlk.o] Error 1
> make[2]: *** [drivers/staging/speakup] Error 2
> make[1]: *** [drivers/staging] Error 2
> make: *** [drivers] Error 2
>
> OTOH, I am using my own build of gcc 4.4.4-8 and none of this was built
> with apt, so YMMV...
>
> I suppose another alternative would be to omit or reverse the patch that
> adds speakup in the first place, if that's more convenient.

I don't think it makes sense to build staging drivers on Debian/m68k.
So can't you default to CONFIG_STAGING=n?

While I do enable them in my test builds to catch portability issues, most of
them don't matter for m68k at all.

> On Mon, 4 Oct 2010, Thorsten Glaser wrote:
>> Finn Thain dixit:
>>
>> >It would be better if we used the same .config, don't you think?
>>
>> *sigh*
>>
>> # apt-get source linux-2.6
>> # cd linux-2.6-2.6.32
>>
>> optionally:
>> # $EDITOR debian/config/m68k/defines
>> ⇒ in [base] comment out everything except “flavours:” and “atari”
>>   to save time compiling the other images
>>
>> then:
>> # debian/rules clean
>> (this may give you an error message)
>> # dpkg-buildpackage -B
>>
>>
>> So, no modifications to stock Debian. Well, except for #598893…

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds