Re: [PATCH 1/1] m68k: add missing I/O macros {in,out}{w,l}_p() for !CONFIG_ISA

Thorsten Glaser
2010-10-04T08:13:16Z

Michael Schmitz dixit:

>please take care not to disturb these macros for any other case than
>the default one (nothing related to ISA emulation configured at all).

The chunk is inside the !CONFIG_ISA part.

>Are you certain the speakup driver has a chance to work, once you got
>it to compile?

Not much, except for the software one. But it’s not the only one, only
the first one, to use the *_p() macros, and given they’re defined in
the CONFIG_ISA case and _some_ are defined for !CONFIG_ISA, this looks
like an obvious omission to me.

Besides, it’s easier to get a bunch of modules that don’t do anything
except say the hardware they steer isn’t available to compile than to
change the config (especially as the latter potentially has to be done
for every new kernel version, and I’d rather keep things working, as
they seem to change very quickly and nobody can keep up really).

bye,
//mirabilos
--
“It is inappropriate to require that a time represented as
seconds since the Epoch precisely represent the number of
seconds between the referenced time and the Epoch.”
-- IEEE Std 1003.1b-1993 (POSIX) Section B.2.2.2