public inbox for linux-m68k@lists.linux-m68k.org
 help / color / mirror / Atom feed
From: Michael Schmitz <schmitzmic@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>,
	Finn Thain <fthain@linux-m68k.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	linux-m68k@lists.linux-m68k.org
Subject: Re: [PATCH RFC 1/2] m68k: Don't deliver signals except at instruction boundary
Date: Wed, 3 May 2023 08:15:45 +1200	[thread overview]
Message-ID: <b1ebac7b-a3e4-fa15-13f4-55aa53fe3130@gmail.com> (raw)
In-Reply-To: <87v8havfq2.fsf@igel.home>

Hi Andreas, Finn,

On 3/05/23 04:51, Andreas Schwab wrote:
> On Mai 02 2023, Finn Thain wrote:
>
>> From: Andreas Schwab <schwab@linux-m68k.org>
>>
>> Signal delivery should only happen at insn boundaries, but due to the
>> way the 030 handles return from bus error exceptions (the insn is resumed,
>> not restarted like on the 040/060) the kernel may do it in the middle of
>> the faulting insn.
> I don't think this will work properly when the address cannot be
> resolved.  The bus error exception will just be raised again
> immediately.

Seems certain, even though we haven't observed that in testing yet 
(haven't designed the test case for that specifically, mind you).

The (slighty hairy) sole solution to this (that I can see) would be to 
only skip signal delivery on the condition that bus_error030 was able to 
correct the bus fault.

In any other case bus_error030 will raise SIGKILL or SIGSEGV which must 
be delivered right away.

Can we infer that from the state of the fault frame after bus_error030, 
or do we have to modify bus_error030 to return success/error codes?

Cheers,

     Michael



  reply	other threads:[~2023-05-02 20:16 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-02  6:50 [PATCH RFC 0/2] 68020/030 signal handling following exceptions Finn Thain
2023-05-02  6:50 ` [PATCH RFC 1/2] m68k: Don't deliver signals except at instruction boundary Finn Thain
2023-05-02 16:51   ` Andreas Schwab
2023-05-02 20:15     ` Michael Schmitz [this message]
2023-05-03  3:22     ` Finn Thain
2023-05-03  3:24       ` Finn Thain
2023-05-02  6:50 ` [PATCH RFC 2/2] m68k: Make allowance for signal delivery following an address error Finn Thain
2023-05-02 21:06   ` Michael Schmitz
2023-05-03  4:11     ` Finn Thain
2023-05-03  5:50       ` Michael Schmitz
2023-05-03  8:02         ` Finn Thain
2023-05-04 21:06           ` Michael Schmitz
2023-05-05  3:14             ` Finn Thain
2023-05-05  5:05               ` Michael Schmitz
2023-05-05 21:35                 ` Michael Schmitz
2023-05-06  0:36                   ` Finn Thain
2023-05-06  1:46                     ` Michael Schmitz
2023-05-06  2:46                       ` Finn Thain
2023-05-06  8:24                         ` Michael Schmitz
2023-05-06  1:11                   ` Finn Thain
2023-05-06  1:54                     ` Michael Schmitz
2023-05-06  2:11                       ` Finn Thain
2023-05-06  2:30                         ` Michael Schmitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b1ebac7b-a3e4-fa15-13f4-55aa53fe3130@gmail.com \
    --to=schmitzmic@gmail.com \
    --cc=fthain@linux-m68k.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox