Re: [PATCH net v9 3/3] net/8390: apne.c - add 100 Mbit support to apne.c driver

Geert Uytterhoeven
2021-11-10T08:27:29Z

Hi Michael,

On Tue, Nov 9, 2021 at 8:39 PM Michael Schmitz <schmitzmic@gmail.com> wrote:
> On 10/11/21 08:25, Randy Dunlap wrote:
> >>>>> There are no other drivers that "select PCCARD" or
> >>>>> "select PCMCIA" in the entire kernel tree.
> >>>>> I don't see any good justification to allow it here.
> >>>>
> >>>> Amiga doesn't use anything from the core PCMCIA code, instead
> >>>> providing its own basic PCMCIA support code.
> >>>>
> >>>> I had initially duplicated some of the cis tuple parser code, but
> >>>> decided to use what's already there instead.
> >>>>
> >>>> I can drop these selects, and add instructions to manually select
> >>>> these options in the Kconfig help section. Seemed a little error prone
> >>>> to me.
> >>>
> >>> Just make it the same as other drivers in this respect, please.
> >>
> >> "depends on PCMCIA" is what I've seen for other drivers. That is not
> >> really appropriate for the APNE driver (8 bit cards work fine with
> >> just the support code from arch/m68k/amiga/pcmcia.c).
> >>
> >> Please confirm that "depends on PCMCIA" is what you want me to use?
> >
> > Hi Michael,
> >
> > I don't want to see this driver using 'select', so that probably only
> > leaves "depends on".
> > But if you or Geert tell me that I am bonkers, so be it. :)
>
> Are you OK with adding CONFIG_PCCARD=y and CONFIG_PCMCIA=y to
> amiga_defconfig to allow APNE to still be built when changed to depend
> on PCMCIA?

Sure. When they become dependencies for APNE, I will update them in
the next defconfig refresh.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds