Re: [PATCH net v9 3/3] net/8390: apne.c - add 100 Mbit support to apne.c driver

Michael Schmitz
2021-11-09T04:56:01Z

Hi Randy,

On 09/11/21 17:09, Randy Dunlap wrote:
> On 11/8/21 8:02 PM, Michael Schmitz wrote:
>> diff --git a/drivers/net/ethernet/8390/Kconfig
>> b/drivers/net/ethernet/8390/Kconfig
>> index a4130e643342..b22c3cf96560 100644
>> --- a/drivers/net/ethernet/8390/Kconfig
>> +++ b/drivers/net/ethernet/8390/Kconfig
>> @@ -136,6 +136,8 @@ config NE2K_PCI
>> config APNE
>> tristate "PCMCIA NE2000 support"
>> depends on AMIGA_PCMCIA
>> + select PCCARD
>> + select PCMCIA
>> select CRC32
>
> Hi,
>
> There are no other drivers that "select PCCARD" or
> "select PCMCIA" in the entire kernel tree.
> I don't see any good justification to allow it here.

Amiga doesn't use anything from the core PCMCIA code, instead providing
its own basic PCMCIA support code.

I had initially duplicated some of the cis tuple parser code, but
decided to use what's already there instead.

I can drop these selects, and add instructions to manually select these
options in the Kconfig help section. Seemed a little error prone to me.

Cheers,

Michael