From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: Thomas Zimmermann <tzimmermann@suse.de>,
gerg@linux-m68k.org, geert@linux-m68k.org
Cc: linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] m68k: Do not include <linux/fb.h>
Date: Sat, 01 Feb 2025 13:16:21 +0100 [thread overview]
Message-ID: <bebe04527833a0eb73b449068ed2f573bb95823e.camel@physik.fu-berlin.de> (raw)
In-Reply-To: <20250131144026.310672-1-tzimmermann@suse.de>
Hi Thomas,
On Fri, 2025-01-31 at 15:40 +0100, Thomas Zimmermann wrote:
> The m68k architecture's source files does not require <linux/fb.h>.
Minor: Replace "does" with "do".
Adrian
> Remove the include statements.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> arch/m68k/kernel/setup_no.c | 1 -
> arch/m68k/kernel/uboot.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/arch/m68k/kernel/setup_no.c b/arch/m68k/kernel/setup_no.c
> index c926da9d5ec28..f9872098f5ca5 100644
> --- a/arch/m68k/kernel/setup_no.c
> +++ b/arch/m68k/kernel/setup_no.c
> @@ -21,7 +21,6 @@
> #include <linux/sched.h>
> #include <linux/delay.h>
> #include <linux/interrupt.h>
> -#include <linux/fb.h>
> #include <linux/module.h>
> #include <linux/mm.h>
> #include <linux/console.h>
> diff --git a/arch/m68k/kernel/uboot.c b/arch/m68k/kernel/uboot.c
> index 8bb1cb3a7490e..5e52ea150d5cb 100644
> --- a/arch/m68k/kernel/uboot.c
> +++ b/arch/m68k/kernel/uboot.c
> @@ -10,7 +10,6 @@
> #include <linux/sched.h>
> #include <linux/delay.h>
> #include <linux/interrupt.h>
> -#include <linux/fb.h>
> #include <linux/module.h>
> #include <linux/mm.h>
> #include <linux/console.h>
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
prev parent reply other threads:[~2025-02-01 12:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-31 14:40 [PATCH] m68k: Do not include <linux/fb.h> Thomas Zimmermann
2025-02-01 11:46 ` Greg Ungerer
2025-02-01 12:16 ` John Paul Adrian Glaubitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bebe04527833a0eb73b449068ed2f573bb95823e.camel@physik.fu-berlin.de \
--to=glaubitz@physik.fu-berlin.de \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox