From: Michael Schmitz <schmitzmic@gmail.com>
To: "Miro Kropáček" <miro.kropacek@gmail.com>
Cc: geert@linux-m68k.org, linux-m68k@vger.kernel.org,
debian-68k@lists.debian.org, Michael Schmitz <schmitz@debian.org>
Subject: Re: [PATCH 14/14] m68k/atari: USB - Add ISP1160 USB host controller support
Date: Sat, 18 Jul 2026 02:40:59 +1200 [thread overview]
Message-ID: <bf394ef0-c22c-44f7-aa05-de6fe665767c@gmail.com> (raw)
In-Reply-To: <CAN5rfbQMfUDDu6jUJaR=u0o-_SeVGA+6FQ-SwBShtq3rN3APCQ@mail.gmail.com>
Miro,
[resent as plain text, sorry]
On 18/07/2026 1:49 AM, Miro Kropáček wrote:
> Hi Michael,
>
> On Mon, 25 Mar 2013 at 11:36, Michael Schmitz <schmitzmic@gmail.com>
> wrote:
>
> Add Atari specific support code for isp116x-hcd driver used by
> EtherNAT
> and NetUSBee adapters. Both use a 16-bit data bus wiring that is
> byte-swapped
> in hardware. The EtherNAT adapter also has quirks relating to
> interrupts
> and needs interrupts disabled until after the chip has been reset.
>
> Debugging of FIFO register access code and NetUSBee support by
> David Galvez
> <dgalvez75@gmail.com> (MiNT driver author).
>
> Signed-off-by: Michael Schmitz <schmitz@debian.org>
>
> Sorry to necro-bump this email thread but this specific commit is
> quite interesting. As far as I understand it, this patch was proposed
> and merged on top of Geert's m68k-queue branch. However five hours
> later there was another set of patches meant for upstream/debian
> merge:
> https://lore.kernel.org/linux-m68k/1364193464-3890-1-git-send-email-schmitz@debian.org
> (interestingly, it wasn't CC'ed to debian-m68k) where you explicitly
> asked (https://lore.kernel.org/linux-m68k/5152996E.50800@gmail.com) to
> skip
> https://lore.kernel.org/linux-m68k/1364193464-3890-3-git-send-email-schmitz@debian.org
> and
> https://lore.kernel.org/linux-m68k/1364193464-3890-12-git-send-email-schmitz@debian.org
> (this one) patches.
>
> "I don't mind for it to live in m68k-queue for a while" ... so, 13
> years later ;), what prevents merging NetUSBee support upstream?
The register access logic was far too hacky for my taste (and I'm sure,
Geert's). Unless a way can be found to handle the endianness issues and
required byte swapping transparently, this patch just isn't up to the
expected standards.
I never tried to submit these patches to linux-usb but I had
interactions with the netdev and scsi maintainers, and despite my best
efforts, some patches that were a lot cleaner than this one never got
accepted.
These days, my EtherNAT board is broken (PHY dead as far as I can tell,
never generates an interrupt when probing for carrier), and the CT60
boots up with broken video mode, so I even if I could improve on this
patch, I can't test the USB code anymore. Haven't had much time for
kernel hacking either recently.
Anyone with access to the hardware and an inclination to get their hands
dirty is welcome to take over these patches and have a little fun with
the code review!
Cheers,
Michael
>
> --
> http://mikro.atari.org
prev parent reply other threads:[~2026-07-17 14:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 1:16 (unknown), Michael Schmitz
2013-03-25 1:16 ` [PATCH 01/14] m68k/atari EtherNEC: remove original EtherNEC driver Michael Schmitz
2013-03-25 1:16 ` [PATCH 02/14] m68k/atari EtherNAT: remove original EtherNAT driver Michael Schmitz
2013-03-25 1:16 ` [PATCH 03/14] m68k/atari: use CONFIG_ATARI in smc91x.h Michael Schmitz
2013-03-25 1:16 ` [PATCH 04/14] m68k/atari: EtherNAT - change number of Atari interrupt sources Michael Schmitz
2013-03-25 1:16 ` [PATCH 05/14] m68k/irq: add handle_polled_irq() for timer based soft interrupts Michael Schmitz
2013-03-25 1:16 ` [PATCH 06/14] m68k/atari: use dedicated irq_chip for timer D interrupts Michael Schmitz
2013-03-25 1:16 ` [PATCH 07/14] m68k/atari: EtherNEC - add platform device support Michael Schmitz
2013-03-25 1:16 ` [PATCH 08/14] m68k/atari: EtherNAT - ethernet support - new driver (smc91x) Michael Schmitz
2013-03-25 1:16 ` [PATCH 09/14] m68k/atari: EtherNEC - ethernet support - new driver (ne.c) Michael Schmitz
2013-03-25 1:16 ` [PATCH 10/14] m68k/atari: EtherNAT - add interrupt chip for Ethernet and USB interrupts Michael Schmitz
2013-03-25 1:16 ` [PATCH 11/14] m68k/atari: Implement 16 bit access macros for ROM port Michael Schmitz
2013-03-25 1:16 ` [PATCH 12/14] m68k: Implement ndelay() based on the existing udelay() logic Michael Schmitz
2013-03-25 1:16 ` [PATCH 13/14] m68k/atari: USB - add platform device definitions for ISP1160 HCD Michael Schmitz
2013-03-25 1:16 ` [PATCH 14/14] m68k/atari: USB - Add ISP1160 USB host controller support Michael Schmitz
[not found] ` <CAN5rfbQMfUDDu6jUJaR=u0o-_SeVGA+6FQ-SwBShtq3rN3APCQ@mail.gmail.com>
2026-07-17 14:40 ` Michael Schmitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf394ef0-c22c-44f7-aa05-de6fe665767c@gmail.com \
--to=schmitzmic@gmail.com \
--cc=debian-68k@lists.debian.org \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@vger.kernel.org \
--cc=miro.kropacek@gmail.com \
--cc=schmitz@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).