From: Jiri Slaby <jirislaby@kernel.org>
To: Thomas Huth <thuth@redhat.com>,
linux-m68k@lists.linux-m68k.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Greg Ungerer <gerg@linux-m68k.org>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] drivers/tty/serial: Remove unused function early_mcf_setup
Date: Tue, 20 Feb 2024 06:11:47 +0100 [thread overview]
Message-ID: <c44bfc7f-7b06-4985-953d-185f8b576a5b@kernel.org> (raw)
In-Reply-To: <20240219164002.520342-1-thuth@redhat.com>
On 19. 02. 24, 17:40, Thomas Huth wrote:
> Compiling a kernel for the ColdFire causes a compiler warning:
>
> drivers/tty/serial/mcf.c:473:12: warning: no previous prototype for
> ‘early_mcf_setup’ [-Wmissing-prototypes]
> 473 | int __init early_mcf_setup(struct mcf_platform_uart *platp)
> | ^~~~~~~~~~~~~~~
>
> This function seems to be completely unused, so let's remove it
> to silence the warning.
And it seems so since the driver addition in 2007 by:
commit 49aa49bfd40d718095669c1c70c9d167b814e29b
Author: Greg Ungerer <gerg@snapgear.com>
Date: Tue Oct 23 14:37:54 2007 +1000
m68knommu: new style ColdFire UART driver
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
thanks,
--
js
suse labs
next prev parent reply other threads:[~2024-02-20 5:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 16:40 [PATCH] drivers/tty/serial: Remove unused function early_mcf_setup Thomas Huth
2024-02-20 5:11 ` Jiri Slaby [this message]
2024-02-20 10:23 ` Geert Uytterhoeven
2024-02-20 13:55 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c44bfc7f-7b06-4985-953d-185f8b576a5b@kernel.org \
--to=jirislaby@kernel.org \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-serial@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox