On Thu, 23 Mar 2023, Geert Uytterhoeven wrote:

> On Thu, Mar 23, 2023 at 9:39 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
> > On Mär 23 2023, Finn Thain wrote:
> >
> > > Checkpatch says "externs should be avoided in .c files" and if this one
> > > appeared twice I would agree. But as it only appears once, I can't see
> > > any advantage to putting it in a new .h file instead of the .c file...
> >
> > Anything wrong with declaring it in <linux/nubus.h>?
> 
> It's not meant for NuBus device drivers (at least in its current form).
> So a drivers/nubus/nubus.h would be the most logical place.
> 

I think Andreas is right inasmuchas the existing prototypes shared between 
drivers/nubus/nubus.c and drivers/nubus/proc.c are found there, and this 
extern is another one of those.

But I take Geert's point that much of include/linux/nubus.h could be moved 
to drivers/nubus/something.h. But is there anything to be gained from 
splitting it up that way?