public inbox for linux-m68k@lists.linux-m68k.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: linux-m68k@lists.linux-m68k.org
Cc: Arnd Bergmann <arnd@arndb.de>, Finn Thain <fthain@linux-m68k.org>,
	Michael Schmitz <schmitzmic@gmail.com>,
	Philip Blundell <philb@gnu.org>,
	Greg Ungerer <gerg@linux-m68k.org>,
	Joshua Thompson <funaho@jurai.org>, Sam Creasey <sammy@sammy.net>,
	Laurent Vivier <laurent@vivier.eu>,
	linux-kernel@vger.kernel.org,
	Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [PATCH v2 00/52] m68k: W=1 fixes
Date: Wed, 13 Sep 2023 16:07:50 +0200	[thread overview]
Message-ID: <cover.1694613528.git.geert@linux-m68k.org> (raw)

	Hi all,

This patch series addresses the remaining (after [1]) warnings seen when
building arch/m68k/ with W=1.  Perhaps surprisingly, this work has
identified and fixes a genuine bug in the Sun-3 TLB handling (see [PATCH
39/52]).

Most of the patches in these series are fairly trivial changes with a
very low risk of introducing any regressions.  For the less trivial
patches, I did look at the assembler output before and after.  As Arnd
is working actively on enabling W=1 rather sooner than later, and if no
one objects, I'm queueing these as fixes for v6.6.

Changes compared to v1[2]:
  - Rebase against v6.6-rc1,
  - Add Acked-by,
  - Include "process.h" instead of <process.h>, to fix in-tree builds,
  - Drop prefix from compiler output,
  - Remove volatile and dedup casts, as suggested by Finn.

Note that this series does not address warnings on Coldfire or MMU-less
systems, but Greg is already taking care of those.

Thanks for your comments!

[1] "[PATCH 0/6] m68k: math-emu: Miscellaneous esthetical improvements"
    https://lore.kernel.org/r/cover.1692283195.git.geert@linux-m68k.org
[2] "[PATCH 00/52] m68k: W=1 fixes"
    https://lore.kernel.org/r/cover.1694093327.git.geert@linux-m68k.org/

Geert Uytterhoeven (52):
  m68k: kernel: Add missing asmlinkage to do_notify_resume()
  m68k: kernel: Include <linux/cpu.h> for trap_init()
  m68k: kernel: Make bad_super_trap() static
  m68k: kernel: Add and use <asm/syscalls.h>
  m68k: kernel: Add and use "ints.h"
  m68k: kernel: Add and use "process.h"
  m68k: kernel: Add and use "ptrace.h"
  m68k: kernel: Add and use "signal.h"
  m68k: kernel: Add and use "traps.h"
  m68k: kernel: Add and use "vectors.h"
  m68k: mm: Include <asm/hwtest.h> for hwreg_()
  m68k: mm: Move paging_init() to common <asm/pgtable.h>
  m68k: mm: Add and use "fault.h"
  m68k: emu: Remove unused vsnprintf() return value in nfprint()
  m68k: emu: Mark version[] __maybe_unused
  m68k: amiga: pcmcia: Replace set but not used variable by READ_ONCE()
  m68k: amiga: Add and use "amiga.h"
  m68k: atari: Document data parameter of stdma_try_lock()
  m68k: atari: Make ikbd_reset() static
  m68k: atari: Make atari_platform_init() static
  m68k: atari: Make atari_stram_map_pages() static
  m68k: atari: Add and use "atari.h"
  m68k: apollo: Remove unused debug console functions
  m68k: apollo: Make local reset, serial, and irq functions static
  m68k: apollo: Replace set but not used variable by READ_ONCE()
  m68k: apollo: Add and use "apollo.h"
  m68k: bvme6000: Make bvme6000_abort_int() static
  m68k: hp300: Include "time.h" for hp300_sched_init()
  m68k: mac: Remove unused sine_data[]
  m68k: mac: Remove unused yday in unmktime()
  m68k: mac: Make mac_platform_init() static
  m68k: mac: Add and use "mac.h"
  m68k: mvme147: Make mvme147_init_IRQ() static
  m68k: mvme16x: Remove unused sink in mvme16x_cons_write()
  m68k: mvme16x: Add and use "mvme16x.h"
  m68k: q40: Add and use "q40.h"
  m68k: sun3/3x: Include <asm/config.h> for config_sun3*()
  m68k: sun3: Improve Sun3/3x DVMA abstraction in <asm/dvma.h>
  m68k: sun3: Fix context restore in flush_tlb_range()
  m68k: sun3: Fix signature of sun3_get_model()
  m68k: sun3: Add missing asmlinkage to sun3_init()
  m68k: sun3: Remove unused orig_baddr in free_baddr()
  m68k: sun3: Remove unused start_page in sun3_bootmem_alloc()
  m68k: sun3: Remove unused vsprintf() return value in prom_printf()
  m68k: sun3: Annotate prom_printf() with __printf()
  m68k: sun3: Make print_pte() static
  m68k: sun3: Make sun3_platform_init() static
  m68k: sun3x: Fix signature of sun3_leds()
  m68k: sun3x: Do not mark dvma_map_iommu() inline
  m68k: sun3x: Make sun3x_halt() static
  m68k: sun3x: Make dvma_print() static
  m68k: sun3/3x: Add and use "sun3.h"

 arch/m68k/amiga/amiga.h            |  5 ++++
 arch/m68k/amiga/amisound.c         |  2 ++
 arch/m68k/amiga/config.c           |  4 +--
 arch/m68k/amiga/pcmcia.c           |  3 +-
 arch/m68k/apollo/apollo.h          |  4 +++
 arch/m68k/apollo/config.c          | 45 ++++++------------------------
 arch/m68k/apollo/dn_ints.c         |  8 ++++--
 arch/m68k/atari/ataints.c          |  3 +-
 arch/m68k/atari/atakeyb.c          |  2 +-
 arch/m68k/atari/atari.h            | 15 ++++++++++
 arch/m68k/atari/atasound.c         |  1 +
 arch/m68k/atari/config.c           | 13 ++-------
 arch/m68k/atari/stdma.c            |  1 +
 arch/m68k/atari/stram.c            |  2 +-
 arch/m68k/atari/time.c             |  2 ++
 arch/m68k/bvme6000/config.c        |  2 +-
 arch/m68k/emu/natfeat.c            |  3 +-
 arch/m68k/emu/nfeth.c              |  2 +-
 arch/m68k/hp300/time.c             |  2 ++
 arch/m68k/include/asm/dvma.h       |  8 +++++-
 arch/m68k/include/asm/oplib.h      |  4 ++-
 arch/m68k/include/asm/pgtable.h    |  9 ++++++
 arch/m68k/include/asm/pgtable_no.h |  1 -
 arch/m68k/include/asm/syscalls.h   | 20 +++++++++++++
 arch/m68k/include/asm/tlbflush.h   |  1 +
 arch/m68k/kernel/early_printk.c    |  4 +--
 arch/m68k/kernel/ints.c            |  2 ++
 arch/m68k/kernel/ints.h            |  7 +++++
 arch/m68k/kernel/process.c         |  1 +
 arch/m68k/kernel/process.h         |  8 ++++++
 arch/m68k/kernel/ptrace.c          |  2 ++
 arch/m68k/kernel/ptrace.h          |  6 ++++
 arch/m68k/kernel/setup_mm.c        |  2 --
 arch/m68k/kernel/signal.c          |  4 ++-
 arch/m68k/kernel/signal.h          |  7 +++++
 arch/m68k/kernel/sys_m68k.c        |  4 +--
 arch/m68k/kernel/traps.c           | 11 ++++----
 arch/m68k/kernel/traps.h           | 10 +++++++
 arch/m68k/kernel/vectors.c         |  3 ++
 arch/m68k/kernel/vectors.h         |  3 ++
 arch/m68k/mac/baboon.c             |  2 ++
 arch/m68k/mac/config.c             | 14 ++--------
 arch/m68k/mac/iop.c                |  2 ++
 arch/m68k/mac/mac.h                | 25 +++++++++++++++++
 arch/m68k/mac/macboing.c           | 11 ++------
 arch/m68k/mac/misc.c               |  5 ++--
 arch/m68k/mac/oss.c                |  2 ++
 arch/m68k/mac/psc.c                |  2 ++
 arch/m68k/mac/via.c                |  2 ++
 arch/m68k/mm/fault.c               |  2 ++
 arch/m68k/mm/fault.h               |  7 +++++
 arch/m68k/mm/hwtest.c              |  2 ++
 arch/m68k/mm/sun3kmap.c            |  6 ++--
 arch/m68k/mm/sun3mmu.c             |  2 +-
 arch/m68k/mvme147/config.c         |  2 +-
 arch/m68k/mvme16x/config.c         |  5 ++--
 arch/m68k/mvme16x/mvme16x.h        |  6 ++++
 arch/m68k/q40/config.c             |  6 ++--
 arch/m68k/q40/q40.h                |  6 ++++
 arch/m68k/q40/q40ints.c            |  2 ++
 arch/m68k/sun3/config.c            | 13 ++++-----
 arch/m68k/sun3/idprom.c            |  4 ++-
 arch/m68k/sun3/intersil.c          |  1 +
 arch/m68k/sun3/leds.c              |  2 ++
 arch/m68k/sun3/mmu_emu.c           |  3 +-
 arch/m68k/sun3/prom/printf.c       |  5 ++--
 arch/m68k/sun3/sun3.h              | 22 +++++++++++++++
 arch/m68k/sun3/sun3dvma.c          | 17 -----------
 arch/m68k/sun3/sun3ints.c          |  2 +-
 arch/m68k/sun3x/config.c           |  6 ++--
 arch/m68k/sun3x/dvma.c             |  5 ++--
 arch/m68k/sun3x/prom.c             |  2 +-
 72 files changed, 281 insertions(+), 148 deletions(-)
 create mode 100644 arch/m68k/amiga/amiga.h
 create mode 100644 arch/m68k/apollo/apollo.h
 create mode 100644 arch/m68k/atari/atari.h
 create mode 100644 arch/m68k/include/asm/syscalls.h
 create mode 100644 arch/m68k/kernel/ints.h
 create mode 100644 arch/m68k/kernel/process.h
 create mode 100644 arch/m68k/kernel/ptrace.h
 create mode 100644 arch/m68k/kernel/signal.h
 create mode 100644 arch/m68k/kernel/traps.h
 create mode 100644 arch/m68k/kernel/vectors.h
 create mode 100644 arch/m68k/mac/mac.h
 create mode 100644 arch/m68k/mm/fault.h
 create mode 100644 arch/m68k/mvme16x/mvme16x.h
 create mode 100644 arch/m68k/q40/q40.h
 create mode 100644 arch/m68k/sun3/sun3.h

-- 
2.34.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

             reply	other threads:[~2023-09-13 14:09 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-13 14:07 Geert Uytterhoeven [this message]
2023-09-13 14:07 ` [PATCH v2 01/52] m68k: kernel: Add missing asmlinkage to do_notify_resume() Geert Uytterhoeven
2023-09-13 14:07 ` [PATCH v2 02/52] m68k: kernel: Include <linux/cpu.h> for trap_init() Geert Uytterhoeven
2023-09-13 14:07 ` [PATCH v2 03/52] m68k: kernel: Make bad_super_trap() static Geert Uytterhoeven
2023-09-13 14:07 ` [PATCH v2 04/52] m68k: kernel: Add and use <asm/syscalls.h> Geert Uytterhoeven
2023-09-13 14:07 ` [PATCH v2 05/52] m68k: kernel: Add and use "ints.h" Geert Uytterhoeven
2023-09-13 14:07 ` [PATCH v2 06/52] m68k: kernel: Add and use "process.h" Geert Uytterhoeven
2023-09-13 14:07 ` [PATCH v2 07/52] m68k: kernel: Add and use "ptrace.h" Geert Uytterhoeven
2023-09-13 14:07 ` [PATCH v2 08/52] m68k: kernel: Add and use "signal.h" Geert Uytterhoeven
2023-09-13 14:07 ` [PATCH v2 09/52] m68k: kernel: Add and use "traps.h" Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 10/52] m68k: kernel: Add and use "vectors.h" Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 11/52] m68k: mm: Include <asm/hwtest.h> for hwreg_() Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 12/52] m68k: mm: Move paging_init() to common <asm/pgtable.h> Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 13/52] m68k: mm: Add and use "fault.h" Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 14/52] m68k: emu: Remove unused vsnprintf() return value in nfprint() Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 15/52] m68k: emu: Mark version[] __maybe_unused Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 16/52] m68k: amiga: pcmcia: Replace set but not used variable by READ_ONCE() Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 17/52] m68k: amiga: Add and use "amiga.h" Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 18/52] m68k: atari: Document data parameter of stdma_try_lock() Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 19/52] m68k: atari: Make ikbd_reset() static Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 20/52] m68k: atari: Make atari_platform_init() static Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 21/52] m68k: atari: Make atari_stram_map_pages() static Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 22/52] m68k: atari: Add and use "atari.h" Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 23/52] m68k: apollo: Remove unused debug console functions Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 24/52] m68k: apollo: Make local reset, serial, and irq functions static Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 25/52] m68k: apollo: Replace set but not used variable by READ_ONCE() Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 26/52] m68k: apollo: Add and use "apollo.h" Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 27/52] m68k: bvme6000: Make bvme6000_abort_int() static Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 28/52] m68k: hp300: Include "time.h" for hp300_sched_init() Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 29/52] m68k: mac: Remove unused sine_data[] Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 30/52] m68k: mac: Remove unused yday in unmktime() Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 31/52] m68k: mac: Make mac_platform_init() static Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 32/52] m68k: mac: Add and use "mac.h" Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 33/52] m68k: mvme147: Make mvme147_init_IRQ() static Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 34/52] m68k: mvme16x: Remove unused sink in mvme16x_cons_write() Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 35/52] m68k: mvme16x: Add and use "mvme16x.h" Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 36/52] m68k: q40: Add and use "q40.h" Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 37/52] m68k: sun3/3x: Include <asm/config.h> for config_sun3*() Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 38/52] m68k: sun3: Improve Sun3/3x DVMA abstraction in <asm/dvma.h> Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 39/52] m68k: sun3: Fix context restore in flush_tlb_range() Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 40/52] m68k: sun3: Fix signature of sun3_get_model() Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 41/52] m68k: sun3: Add missing asmlinkage to sun3_init() Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 42/52] m68k: sun3: Remove unused orig_baddr in free_baddr() Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 43/52] m68k: sun3: Remove unused start_page in sun3_bootmem_alloc() Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 44/52] m68k: sun3: Remove unused vsprintf() return value in prom_printf() Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 45/52] m68k: sun3: Annotate prom_printf() with __printf() Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 46/52] m68k: sun3: Make print_pte() static Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 47/52] m68k: sun3: Make sun3_platform_init() static Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 48/52] m68k: sun3x: Fix signature of sun3_leds() Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 49/52] m68k: sun3x: Do not mark dvma_map_iommu() inline Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 50/52] m68k: sun3x: Make sun3x_halt() static Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 51/52] m68k: sun3x: Make dvma_print() static Geert Uytterhoeven
2023-09-13 14:08 ` [PATCH v2 52/52] m68k: sun3/3x: Add and use "sun3.h" Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1694613528.git.geert@linux-m68k.org \
    --to=geert@linux-m68k.org \
    --cc=arnd@arndb.de \
    --cc=fthain@linux-m68k.org \
    --cc=funaho@jurai.org \
    --cc=gerg@linux-m68k.org \
    --cc=laurent@vivier.eu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=philb@gnu.org \
    --cc=sammy@sammy.net \
    --cc=schmitzmic@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox