Re: [PATCH 05/28] csky: introduce arch_zone_limits_init()

Guo Ren
2025-12-29T01:25:57Z

On Sun, Dec 28, 2025 at 8:41 PM Mike Rapoport <rppt@kernel.org> wrote:
>
> From: "Mike Rapoport (Microsoft)" <rppt@kernel.org>
>
> Move calculations of zone limits to a dedicated arch_zone_limits_init()
> function.
>
> Later MM core will use this function as an architecture specific callback
> during nodes and zones initialization and thus there won't be a need to
> call free_area_init() from every architecture.
>
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
> ---
> arch/csky/kernel/setup.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/arch/csky/kernel/setup.c b/arch/csky/kernel/setup.c
> index e0d6ca86ea8c..8968815d93e6 100644
> --- a/arch/csky/kernel/setup.c
> +++ b/arch/csky/kernel/setup.c
> @@ -51,6 +51,14 @@ static void __init setup_initrd(void)
> }
> #endif
>
> +void __init arch_zone_limits_init(unsigned long *max_zone_pfns)
> +{
> + max_zone_pfns[ZONE_NORMAL] = max_low_pfn;
> +#ifdef CONFIG_HIGHMEM
> + max_zone_pfns[ZONE_HIGHMEM] = max_pfn;
> +#endif
> +}
> +
LGTM!

Acked-by: Guo Ren <guoren@kernel.org>

> static void __init csky_memblock_init(void)
> {
> unsigned long lowmem_size = PFN_DOWN(LOWMEM_LIMIT - PHYS_OFFSET_OFFSET);
> @@ -83,12 +91,9 @@ static void __init csky_memblock_init(void)
> setup_initrd();
> #endif
>
> - max_zone_pfn[ZONE_NORMAL] = max_low_pfn;
> -
> mmu_init(min_low_pfn, max_low_pfn);
>
> #ifdef CONFIG_HIGHMEM
> - max_zone_pfn[ZONE_HIGHMEM] = max_pfn;
>
> highstart_pfn = max_low_pfn;
> highend_pfn = max_pfn;
> @@ -97,6 +102,7 @@ static void __init csky_memblock_init(void)
>
> dma_contiguous_reserve(0);
>
> + arch_zone_limits_init(max_zone_pfn);
> free_area_init(max_zone_pfn);
> }
>
> --
> 2.51.0
>

--
Best Regards
Guo Ren