From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1549C43334 for ; Mon, 6 Jun 2022 16:41:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241848AbiFFQlG (ORCPT ); Mon, 6 Jun 2022 12:41:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241852AbiFFQk5 (ORCPT ); Mon, 6 Jun 2022 12:40:57 -0400 X-Greylist: delayed 324 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 06 Jun 2022 09:40:56 PDT Received: from mailout.easymail.ca (mailout.easymail.ca [64.68.200.34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FA941476A8 for ; Mon, 6 Jun 2022 09:40:54 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id F0673E0E57; Mon, 6 Jun 2022 16:35:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo08-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo08-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hhyNN48mX6Hb; Mon, 6 Jun 2022 16:35:29 +0000 (UTC) Received: from mail.gonehiking.org (unknown [38.15.45.1]) by mailout.easymail.ca (Postfix) with ESMTPA id 87721E0E2D; Mon, 6 Jun 2022 16:35:29 +0000 (UTC) Received: from [192.168.1.4] (internal [192.168.1.4]) by mail.gonehiking.org (Postfix) with ESMTP id 689583EF5B; Mon, 6 Jun 2022 10:35:28 -0600 (MDT) Message-ID: Date: Mon, 6 Jun 2022 10:35:28 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Reply-To: khalid@gonehiking.org Subject: Re: [PATCH 5/6] scsi: remove stale BusLogic driver Content-Language: en-US To: Arnd Bergmann Cc: Arnd Bergmann , Jakub Kicinski , Christoph Hellwig , Marek Szyprowski , Robin Murphy , iommu@lists.linux-foundation.org, linux-scsi@vger.kernel.org, Manohar Vanga , Martyn Welch , Greg Kroah-Hartman , linuxppc-dev@lists.ozlabs.org, linux-arch@vger.kernel.org, linux-alpha@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-parisc@vger.kernel.org, Denis Efremov , "Maciej W . Rozycki" , Matt Wang References: <20220606084109.4108188-1-arnd@kernel.org> <20220606084109.4108188-6-arnd@kernel.org> From: Khalid Aziz In-Reply-To: <20220606084109.4108188-6-arnd@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-m68k@vger.kernel.org On 6/6/22 02:41, Arnd Bergmann wrote: > From: Arnd Bergmann > > The BusLogic driver is the last remaining driver that relies on the > deprecated bus_to_virt() function, which in turn only works on a few > architectures, and is incompatible with both swiotlb and iommu support. > > Before commit 391e2f25601e ("[SCSI] BusLogic: Port driver to 64-bit."), > the driver had a dependency on x86-32, presumably because of this > problem. However, the change introduced another bug that made it still > impossible to use the driver on any 64-bit machine. > > This was in turn fixed in commit 56f396146af2 ("scsi: BusLogic: Fix > 64-bit system enumeration error for Buslogic"), 8 years later. > > The fact that this was found at all is an indication that there are > users, and it seems that Maciej, Matt and Khalid all have access to > this hardware, but if it took eight years to find the problem, > it's likely that nobody actually relies on it. > > Remove it as part of the global virt_to_bus()/bus_to_virt() removal. > If anyone is still interested in keeping this driver, the alternative > is to stop it from using bus_to_virt(), possibly along the lines of > how dpt_i2o gets around the same issue. > > Cc: Maciej W. Rozycki > Cc: Matt Wang > Cc: Khalid Aziz > Signed-off-by: Arnd Bergmann > --- > Documentation/scsi/BusLogic.rst | 581 --- > Documentation/scsi/FlashPoint.rst | 176 - > MAINTAINERS | 7 - > drivers/scsi/BusLogic.c | 3727 -------------- > drivers/scsi/BusLogic.h | 1284 ----- > drivers/scsi/FlashPoint.c | 7560 ----------------------------- > drivers/scsi/Kconfig | 24 - > 7 files changed, 13359 deletions(-) > delete mode 100644 Documentation/scsi/BusLogic.rst > delete mode 100644 Documentation/scsi/FlashPoint.rst > delete mode 100644 drivers/scsi/BusLogic.c > delete mode 100644 drivers/scsi/BusLogic.h > delete mode 100644 drivers/scsi/FlashPoint.c I would say no to removing BusLogic driver. Virtualbox is another consumer of this driver. This driver is very old but I would rather fix the issues than remove it until we do not have any users. Thanks, Khalid