From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A7F3C433FE for ; Fri, 25 Feb 2022 09:35:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239151AbiBYJgO (ORCPT ); Fri, 25 Feb 2022 04:36:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237787AbiBYJgN (ORCPT ); Fri, 25 Feb 2022 04:36:13 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D6C211F767A for ; Fri, 25 Feb 2022 01:35:41 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DF2EF106F; Fri, 25 Feb 2022 01:35:40 -0800 (PST) Received: from [10.163.51.16] (unknown [10.163.51.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A5E803F70D; Fri, 25 Feb 2022 01:35:38 -0800 (PST) Subject: Re: [PATCH V2 08/30] m68k/mm: Enable ARCH_HAS_VM_GET_PAGE_PROT To: Geert Uytterhoeven , Andrew Morton Cc: Linux MM , Linux Kernel Mailing List , Christoph Hellwig , Linux-Arch , Thomas Bogendoerfer , linux-m68k References: <1645425519-9034-1-git-send-email-anshuman.khandual@arm.com> <1645425519-9034-9-git-send-email-anshuman.khandual@arm.com> From: Anshuman Khandual Message-ID: Date: Fri, 25 Feb 2022 15:05:36 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-m68k@vger.kernel.org On 2/25/22 2:32 PM, Geert Uytterhoeven wrote: > Hi Anshuman, Andrew, > > On Mon, Feb 21, 2022 at 12:54 PM Geert Uytterhoeven > wrote: >> On Mon, Feb 21, 2022 at 9:45 AM Anshuman Khandual >> wrote: >>> This defines and exports a platform specific custom vm_get_page_prot() via >>> subscribing ARCH_HAS_VM_GET_PAGE_PROT. Subsequently all __SXXX and __PXXX >>> macros can be dropped which are no longer needed. >>> >>> Cc: Thomas Bogendoerfer >>> Cc: linux-m68k@lists.linux-m68k.org >>> Cc: linux-kernel@vger.kernel.org >>> Signed-off-by: Anshuman Khandual >> >> Thanks for your patch! >> >>> --- a/arch/m68k/mm/init.c >>> +++ b/arch/m68k/mm/init.c >>> @@ -128,3 +128,107 @@ void __init mem_init(void) >>> memblock_free_all(); >>> init_pointer_tables(); >>> } >>> + >>> +#ifdef CONFIG_COLDFIRE >>> +/* >>> + * Page protections for initialising protection_map. See mm/mmap.c >>> + * for use. In general, the bit positions are xwr, and P-items are >>> + * private, the S-items are shared. >>> + */ >>> +pgprot_t vm_get_page_prot(unsigned long vm_flags) >> >> Wouldn't it make more sense to add this to arch/m68k/mm/mcfmmu.c? > > It's not just about sense, but also about correctness. > The CF_PAGE_* definitions below exist only if CONFIG_MMU=y, > thus causing breakage for cfnommu in today's linux-next. > http://kisskb.ellerman.id.au/kisskb/buildresult/14701640/ As mentioned before, will do all these necessary changes in the next version probably sometime earlier next week. I was waiting for other reviews (if any) till now.