From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel-space.org (v2202511311555398556.powersrv.de [46.38.245.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2268363099 for ; Tue, 5 May 2026 05:54:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.38.245.6 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777960499; cv=none; b=qUWG8bIlz24Gqqc8bPyEFllgmAwxnTK+okAl3RYPpo/tfdI1c0iH2pFl62uf4AfQMf3+P1ie85keubQ8ek5UTSr57x1livdJpgSkxgrRnDYCYGGbQS2K/0MqFqPyf3q+YxnjM2q5MUFPTJ2frSMEa5JmrUwHcfeP2kJDMN+MGKg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777960499; c=relaxed/simple; bh=RLY645KOSH0N06zPXBMbc5TxsXmS3lPUbHgVnhI4aN4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jII+JldkC0ltOTSHESsKFSQOY8K2v5Wo4b0COzWBvOuEf6V+RU+uL3TC5DACQ9oD4vzRijVXMihGK9GskEWB3vpr8KFtml/ZTM5LGCvW7Ng4EW0xUnVK5fVuXfEbjEKQJagwo/0RQJq0jaqLE/8Q35tKEaGmx18Db1K0VdpOtAg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=kernel-space.org; spf=pass smtp.mailfrom=kernel-space.org; dkim=pass (1024-bit key) header.d=kernel-space.org header.i=@kernel-space.org header.b=iGyIV0po; arc=none smtp.client-ip=46.38.245.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=kernel-space.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel-space.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=kernel-space.org header.i=@kernel-space.org header.b="iGyIV0po" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-space.org; s=s1; t=1777960490; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JpWMGrla8ujc+yJ0xsFuIV5CslqX+fFHzMu968BtRqs=; b=iGyIV0pokGRqOSR6yVS5OD8OgQUH1DfaNQTvqfIAtARXgTj/lyciwqZ7txwOhzCs36wjBW CzOy3NZSCXrGBnvWRZPQxNZsamZotkReSv4X+BNBw2wjhYq6GEVyq7f7/A2fZprO2PU6ER SUG2FJhrzSqiKnk42VeFQeSg3agl4qw= Received: from [IPV6:2a07:7e81:7daa:0:62cf:84ff:feee:627] ( [2a07:7e81:7daa:0:62cf:84ff:feee:627]) by oreshnik (OpenSMTPD) with ESMTPSA id e45b9491 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 5 May 2026 05:54:50 +0000 (UTC) Message-ID: Date: Tue, 5 May 2026 07:54:49 +0200 Precedence: bulk X-Mailing-List: linux-m68k@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 10/10] iio: dac: add mcf54415 DAC To: Greg Ungerer , Arnd Bergmann , Geert Uytterhoeven , Steven King , Maxime Coquelin , Alexandre Torgue , Jonathan Cameron , David Lechner , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: Greg Ungerer , linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org, Angelo Dureghello References: <20260504-wip-stmark2-dac-v1-0-874c36a4910d@baylibre.com> <20260504-wip-stmark2-dac-v1-10-874c36a4910d@baylibre.com> <965cb599-37ac-4d69-a8c0-015152037139@app.fastmail.com> <31297e73-52a5-42a0-9676-ecf057f7c21e@linux-m68k.org> Content-Language: en-US, it From: Angelo Dureghello In-Reply-To: <31297e73-52a5-42a0-9676-ecf057f7c21e@linux-m68k.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Greg, Arnd, On 5/5/26 04:06, Greg Ungerer wrote: > > On 5/5/26 03:27, Arnd Bergmann wrote: >> On Mon, May 4, 2026, at 19:16, Angelo Dureghello wrote: >> >>> +static void mcf54415_dac_exit(void *data) >>> +{ >>> +    struct mcf54415_dac *info = data; >>> +    int val; >>> + >>> +    val = readw(info->regs + MCF54415_DAC_CR); >>> +    val |= MCF54415_DAC_CR_PDN; >>> +    writew(val, info->regs + MCF54415_DAC_CR); >>> +} >> >> We've recently discussed changing the MMIO accessors on coldfire >> to behave like all the other ones, which makes readw() and writew() >> have an implicit byteswap. An additional driver means one more >> place to change during the conversion. Maybe you can use the >> new mcf_readw()/mcf_writew() helpers that Greg has started >> introducing? Those will keep using native big-endian register >> definitions. > > Yes, please :-) > Those newly introduced mcf_readX/mcf_writeX are in the for-next branch > of the m68knommu git tree now, they have not hit mainline yet, hopefully > in the next merge cycle. > > Somewhat related, I will have patches out for the other affected drivers > over the next few days. ack, sure, will do, also understanding properly the thing, since was out from m68k for some time.> > Regards > Greg > thanks, regards, angelo>